I've fixed the crash and added the query as zorba/eval/eval16.xq.
--
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Stage AddTestSuitesUbuntu failed.
Check console output at
http://jenkins.lambda.nu/job/AddTestSuitesUbuntu/125/console to view the
results.
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/skip-items into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your
- In ZorbaCollectionIterator::initCollection lines 307 and 326, you eventually
add skipCount twice. Something smells spooky here.
Yes, it seems it was added twice. I've fixed it.
I've also added the skip() function to the EvalIterator.
--
--
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Stage TestZorbaUbuntu failed.
1 tests failed (8415 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/123/testReport/ to view the
results.
--
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723 :
Votes: {'Needs Information': 1, 'Approve': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/56/console to
view the results.
--
Review: Needs Fixing
The following query crashes:
xquery version 3.0;
import module namespace ddl =
http://www.zorba-xquery.com/modules/store/dynamic/collections/ddl;;
import module namespace dml =
http://www.zorba-xquery.com/modules/store/dynamic/collections/dml;;
import module namespace e =
I've looked into the index probe iterators but they already optimize any
skipping. They take a Skip parameter and then they push it into an underlying
iterator e.g. ProbeValueTreeIndexIterator which handles the skip internally. So
there is nothing to be done there.
I've pushed the pending
Review: Needs Information
Looks good to me. Only two issues.
- The thing with the probe iterators is that there are additional functions
called probe-*-skip that allow
you to skip explicitly. However, subsequence is not rewritten into these
functions. We will need to override the skip function
- Shouldn't skip take an unsigned integer?
The parameters to fn:subsequence and co are all signed. E.g. you can pass a
negative skip.
- Why is the while loop in collections_impl.cpp:397 necessary if
initCollection is called before? I think there might be a bug in
initCollection.
Review: Needs Fixing
- Shouldn't skip take an unsigned integer?
- Why is the while loop in collections_impl.cpp:397 necessary if initCollection
is called before? I think there might be a bug in initCollection. Specifically,
the else block in line 298 is never called because the
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/skip-items into
lp:zorba.
Commit message:
Implemented the Skip-items facility
Requested reviews:
Nicolae Brinza (nbrinza)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Implemented the
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba
21 matches
Mail list logo
