Review: Approve
I think you're correct, although at this point I'm not really sure either. For
what it's worth, ZORBA_FIND_JNI() doesn't actually do the finding of JNI; it
sets up JAVA_HOME in some magic way, and then just calls FIND_PACKAGE(JNI)
anyway. So it depends on FindJNI.cmake existing
Attempt to merge into lp:zorba/data-formatting-module failed due to conflicts:
contents conflict in cmake_modules/FindJNI.cmake
--
https://code.launchpad.net/~davidagraf/zorba/data-formatting-module-bug-989490/+merge/110273
Your team Zorba Coders is subscribed to branch
Hey Chris
This merge proposal got lost. Do you know the status of this? I lost the
overview.
But I guess that FIND_PACKAGE(JNI) in all the java modules should be replaced
with ZORBA_FIND_JNI(). Do you agree?
--
Review: Needs Information
Have you tested this on Windows? I'm actually not sure that you can delete the
Windows/FindJNI.cmake file; it does something different.
--
https://code.launchpad.net/~davidagraf/zorba/data-formatting-module-bug-989490/+merge/110273
Your team Zorba Coders is subscribed
Review: Needs Information
Hello Chris. Unfortunately now :-(. Sorry. But before testing, I need to fix
something else. I just saw this:
bzr diff -c 31
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2012-05-23 09:12:37 +
+++ CMakeLists.txt 2012-06-04 11:42:06 +
@@ -16,12
It is necessary for now, primarily to support building the
data-formatting-module against an *installed* Zorba with the util-jvm module.
In that case, util-jvm's CMakeLists.txt won't be run, so FIND_PACKAGE(Java) and
(JNI) won't be run either.
A better solution would probably be to add those
6 matches
Mail list logo
