[Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
The proposal to merge lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 -- https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
The proposal to merge lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 -- https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
The proposal to merge lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 -- https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
The proposal to merge lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 -- https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
The proposal to merge lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 -- https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
The proposal to merge lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 -- https://code.launchpad.net/~fcavalieri/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba
The proposal to merge lp:~fcavalieri/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/updrevalidate-2011-10-13T07-32-54.096Z/log.html -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba
Validation queue job updrevalidate-2011-10-13T07-32-54.096Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Pending. -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba
The proposal to merge lp:~fcavalieri/zorba/updrevalidate into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba
The proposal to merge lp:~fcavalieri/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/updrevalidate-2011-10-13T08-18-04.321Z/log.html -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba
Validation queue job updrevalidate-2011-10-13T08-18-04.321Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Pending. -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~fcavalieri/zorba/updrevalidate into lp:zorba
The proposal to merge lp:~fcavalieri/zorba/updrevalidate into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 -- https://code.launchpad.net/~fcavalieri/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba
Hello Daniel Thanks for fixing the issue that fast. Unfortunately, I didn't approve the patch because of two comments I have: 1) Does the fix in src/compiler/expression/expr.cpp belongs do the tumbling window for fix or is this something else? If yes, we need an extra test for this. Or even better, we need an extra merge for it. 2) Maybe I am wrong and something is not correct in my CMake configuration. The test you added for the tumbling window bug does not really make sense to. Because it is a normal rbkt test. It passes on my system without your fix. Can't you just add the test from the bug report? -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79160 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
> > > > function name too long? node-structural-information > > > > > > Any suggestions? > > > > > > node-information > > > node-position > > > node-uri > > > structural-information > > I like node-information as name for both - the module and the function. > > That's at least consistent with the node-reference module and function. > > Fixed I dislike the name "node-information" because it conveys no information about what the module is doing. I think "node-position", though not perfect, is the most accurate one. The comments in the .xq file speak of "node positions" as well. -- https://code.launchpad.net/~zorba-coders/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 872732] Re: K2-NamespaceURIForPrefixFunc-2 test fails
In XQTS_1_0_3 the expected result for this test is 'true'.
According to the:
- W3C F&O Spec:
http://www.w3.org/TR/xpath-functions-30/#func-namespace-uri-for-prefix
- decisions taken in bug 11590:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11590
The correct result in this case is the empty sequence: because () eq ""
returns ()
Because of the fact that at this moment the RQ uses XQTS_1_0_3, the test
test/rbkt/w3c_testsuite/XQuery/Functions/QNameFunc/NamespaceURIForPrefixFunc/K2-NamespaceURIForPrefixFunc-2
is marked as an expected failure in
test/tbkt/Queries/CMakeLists.txt.
Also the test was manually added in the
test/tbkt/Queries/w3c_known_failures.txt in order for the change to go through
the RQ.
The proposed changes for this bug can be found on this public branch: lp
:~zorba-coders/zorba/bug_872732
** Bug watch added: W3C Bugzilla #11590
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11590
--
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/872732
Title:
K2-NamespaceURIForPrefixFunc-2 test fails
Status in Zorba - The XQuery Processor:
New
Bug description:
this is the ctest output:
test
w3c_testsuite/XQuery/Functions/QNameFunc/NamespaceURIForPrefixFunc/K2-NamespaceURIForPrefixFunc-2
=== Query: ===
(:***:)
(: Test: K2-NamespaceURIForPrefixFunc-2 :)
(: Written by: Frans Englich :)
(: Date: 2007-11-22T11:31:21+01:00 :)
(: Purpose: Test that the correct default namespace is picked up(#2). :)
(:***:)
namespace-uri-for-prefix("", exactly-one(http://www.example.com/A";
xmlns:A="http://www.example.com/C";>
http://www.example.com/C"; xmlns=""/>
/b)) eq ""
=== end of Query ===
=== Result: ===
true
=== end of result ===
testdriver: non-canonical result for reference result # 1 doesn't match.
Actual and Reference canonical results are not identical
Actual Canonical Result:
true
Reference Canonical Result:
See line 1, col 6 of expected result.
Actual:
Expected: <>
testdriver: canonical result for reference result # 1 doesn't match.
testdriver: none of the reference results matched
To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/872732/+subscriptions
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug_872732 into lp:zorba
Sorin Marian Nasoi has proposed merging lp:~zorba-coders/zorba/bug_872732 into
lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug_872732/+merge/79272
Fixed the bug #872732 according to the:
- W3C spec:
http://www.w3.org/TR/xpath-functions-30/#func-namespace-uri-for-prefix
- W3C decision from : http://www.w3.org/Bugs/Public/show_bug.cgi?id=11590
Marked the test
test/rbkt/w3c_testsuite/XQuery/Functions/QNameFunc/NamespaceURIForPrefixFunc/K2-NamespaceURIForPrefixFunc-2
as expected failure in the:
- test/rbkt/Queries/CMakeLists.txt
- test/rbkt/Queries/w3c_known_failures.txt
because the RQ uses XQTS_1_0_3, where the expected result for this test is
wrong.
--
https://code.launchpad.net/~zorba-coders/zorba/bug_872732/+merge/79272
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/runtime/qnames/qnames_impl.cpp'
--- src/runtime/qnames/qnames_impl.cpp 2011-07-19 19:35:04 +
+++ src/runtime/qnames/qnames_impl.cpp 2011-10-13 13:12:36 +
@@ -1,12 +1,12 @@
/*
* Copyright 2006-2008 The FLWOR Foundation.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -52,7 +52,7 @@
PlanIteratorState* state;
DEFAULT_STACK_INIT(PlanIteratorState, state, planState);
- if (consumeNext(itemQName, theChild0.getp(), planState ))
+ if (consumeNext(itemQName, theChild0.getp(), planState ))
{
itemQName->getStringValue2(qname);
@@ -60,7 +60,7 @@
index = qname.find(":", 0, 1);
-if (index != zstring::npos)
+if (index != zstring::npos)
{
resPre = qname.substr(0, index);
resLocal = qname.substr(index+1, qname.size() - index);
@@ -70,7 +70,7 @@
throw XQUERY_EXCEPTION(
err::FOCA0002, ERROR_PARAMS( qname ), ERROR_LOC(loc)
);
-}
+}
else
{
resLocal = qname;
@@ -80,8 +80,8 @@
err::FOCA0002, ERROR_PARAMS( qname ), ERROR_LOC(loc)
);
}
-
-if (consumeNext(itemElem, theChild1, planState ))
+
+if (consumeNext(itemElem, theChild1, planState ))
{
itemElem->getNamespaceBindings(NamespaceBindings);
@@ -104,7 +104,7 @@
err::FONS0004, ERROR_PARAMS( resPre ), ERROR_LOC( loc )
);
}
-
+
GENV_ITEMFACTORY->createQName(result, resNs, resPre, resLocal);
STACK_PUSH(true, state);
@@ -128,7 +128,7 @@
PlanIteratorState* state;
DEFAULT_STACK_INIT(PlanIteratorState, state, planState);
- if (consumeNext(itemURI, theChild0.getp(), planState ))
+ if (consumeNext(itemURI, theChild0.getp(), planState ))
{
itemURI->getStringValue2(resNs);
@@ -138,12 +138,12 @@
consumeNext(itemQName, theChild1.getp(), planState );
itemQName->getStringValue2(qname);
-
+
ascii::trim_whitespace(qname);
index = qname.find(":", 0, 1);
- if (index != zstring::npos)
+ if (index != zstring::npos)
{
if (resNs.empty())
throw XQUERY_EXCEPTION(
@@ -152,12 +152,12 @@
resPre = qname.substr(0, index);
resLocal = qname.substr(index+1, qname.size() - index);
- }
+ }
else
{
resLocal = qname;
}
-
+
if ((index != zstring::npos && ! GENV_GCAST.castableToNCName(resPre)) ||
! GENV_GCAST.castableToNCName(resLocal))
{
@@ -209,7 +209,7 @@
//11.2.2 fn:prefix-from-QName
bool PrefixFromQNameIterator::nextImpl(
-store::Item_t& result,
+store::Item_t& result,
PlanState& planState) const
{
store::Item_t item;
@@ -232,8 +232,8 @@
//11.2.3 fn:local-name-from-QName
bool LocalNameFromQNameIterator::nextImpl(
-store::Item_t& result,
-PlanState& planState) const
+store::Item_t& result,
+PlanState& planState) const
{
store::Item_t item;
zstring localName;
@@ -253,7 +253,7 @@
//11.2.4 fn:namespace-uri-from-QName
bool NamespaceUriFromQNameIterator::nextImpl(
store::Item_t& result,
-PlanState& planState) const
+PlanState& planState) const
{
store::Item_t item;
zstring ns;
@@ -277,6 +277,7 @@
{
store::Item_t itemPrefix, itemElem;
zstring resNs;
+ zstring prefix;
bool found = false;
store::NsBindings NamespaceBindings;
store::NsBindings::const_iterator iter;
@@ -284,43 +285,35 @@
PlanIteratorState* state;
DEFAULT_STACK_INIT(PlanIteratorState, state, planState);
-// According to W3C bug #11590 comment #9
-// http://www.w3.org/Bugs/Public/show_bug.cgi?id=11590#c9
-// namespace-uri-for-prefix('', )
-// and
-// namespace-uri-for-prefix((), )
-// should return the empty sequence
if (!consume
Re: [Zorba-coders] [Merge] lp:~fcavalieri/zorba/structuralrelationships2 into lp:zorba
> > > > > function name too long? node-structural-information > > > > > > > > Any suggestions? > > > > > > > > node-information > > > > node-position > > > > node-uri > > > > structural-information > > > I like node-information as name for both - the module and the function. > > > That's at least consistent with the node-reference module and function. > > > > Fixed > > I dislike the name "node-information" because it conveys no information about > what the module is doing. I think "node-position", though not perfect, is the > most accurate one. The comments in the .xq file speak of "node positions" as > well. I'm fine with node-position. -- https://code.launchpad.net/~zorba-coders/zorba/structuralrelationships2/+merge/78395 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/updrevalidate-2011-10-13T16-27-57.947Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
Validation queue job updrevalidate-2011-10-13T16-27-57.947Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 872796] Re: validate-in-place can break other update primitives
** Changed in: zorba Status: New => Fix Released -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/872796 Title: validate-in-place can break other update primitives Status in Zorba - The XQuery Processor: Fix Released Bug description: The validate-in-place function can make other update primitives uneffective. The following query should return new new but it returns old new. import module namespace schema = "http://www.zorba-xquery.com/modules/schema";; import schema namespace d="http://www.example.com/doc"; at "test24.xsd"; import module namespace file = "http://expath.org/ns/file";; declare revalidation lax; variable $doc:=http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://www.zorba-xquery.org/schema";> old ; ( schema:validate-in-place($doc), replace value of node $doc//*:a with "new" ); variable $res1:=string($doc//*:a); ( replace value of node $doc//*:a with "new" ); ($res1,string($doc//*:a)) To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/872796/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 872799] Re: validate-in-place can set incorrect types
** Changed in: zorba
Status: New => Fix Released
--
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/872799
Title:
validate-in-place can set incorrect types
Status in Zorba - The XQuery Processor:
Fix Released
Bug description:
validate-in-place can set incorrect types.
The following query should produce a "smallEl" with type "smallEl", but it
produces a "smallEl" typed as "bigEl".
import module namespace schema = "http://www.zorba-xquery.com/modules/schema";;
import schema namespace d="http://www.example.com/doc"; at "test23.xsd";
import module namespace file = "http://expath.org/ns/file";;
declare revalidation lax;
variable $doc:=http://www.w3.org/2001/XMLSchema-instance";
xmlns="http://www.zorba-xquery.org/schema";>
old
;
(
schema:validate-in-place($doc),
rename node $doc/*:bigEl as
QName("http://www.zorba-xquery.org/schema","smallEl";)
);
for $x in ($doc//*)
return ()
Schema
http://www.w3.org/2001/XMLSchema";
targetNamespace="http://www.zorba-xquery.org/schema";
xmlns="http://www.zorba-xquery.org/schema";
elementFormDefault="qualified">
To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/872799/+subscriptions
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/updrevalidate into lp:zorba. Requested reviews: Federico Cavalieri (fcavalieri) Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
Federico, I forgot to submit some cosmetic changes to this branch before pushing the "approve" button. So, now I have created this new merge proposal. Can you please review? Thanks!. -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
Sure, but to me it looks like no change has been made at all (Preview Diff contains only the word Empty) and no "In a few minutes the diff will be updated". Maybe I just have to wait... -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
> Sure, but to me it looks like no change has been made at all (Preview Diff > contains only the word Empty) and no "In a few minutes the diff will be > updated". Maybe I just have to wait... Yes I just had to wait -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
Why variable numUpdates in PULImpl::mergeUpdateList is declared, assigned but never read? -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~markos-za/zorba/indexes into lp:zorba
The proposal to merge lp:~markos-za/zorba/indexes into lp:zorba has been updated. Commit Message changed to: 1. Big reorg of the code for general indexes: 1.1 Unified code for creating hash- and tree-based index 1.2 Unified code among different kinds of probe functions 1.3 Improved performance by taking advantage of the fact the general indexes cannot have more than one key expression. 2. Updated/fixed the documentation in the xqddf spec and the indexes/dml.xq file. For more details, see: https://code.launchpad.net/~markos-za/zorba/indexes/+merge/79334 -- https://code.launchpad.net/~markos-za/zorba/indexes/+merge/79334 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~markos-za/zorba/indexes into lp:zorba
Matthias, I think I am done with the coding part. I am still working on the documentation, so that part is not finished yet. But feel free to start looking at the code as soon as you like. Since this is a rather big reorg, I am afraid that diffs will not help very much. You just have to look at the new code and decide if it is good enough. Of course, it's up to you to decide how deep of a review you want to do. -- https://code.launchpad.net/~markos-za/zorba/indexes/+merge/79334 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~markos-za/zorba/indexes into lp:zorba
The proposal to merge lp:~markos-za/zorba/indexes into lp:zorba has been updated. Commit Message changed to: 1. Big reorg of the code for general indexes: 1.1 Unified code for creating hash- and tree-based index 1.2 Unified code among different kinds of probe functions 1.3 Improved performance by taking advantage of the fact the general indexes cannot have more than one key expression. 2. Updated/fixed the documentation in the xqddf spec and the indexes/dml.xq file. 3. Put a restriction on the use of the uniqueness property: a general, untyped index cannot be unique. For more details, see: https://code.launchpad.net/~markos-za/zorba/indexes/+merge/79334 -- https://code.launchpad.net/~markos-za/zorba/indexes/+merge/79334 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
> Why variable numUpdates in PULImpl::mergeUpdateList is declared, assigned but > never read? Good question :) The easy answer is to just remove it. But I think it can actually be used to replace the myList.size() in the 2 for loops at lines 1289 and 1308. Even though new entries can be added in myList during each iteration of the outer for-loop, I think that during those 2 inner for-loops it is ok to search myList only up to numUpdates. Do you agree? -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba
> > Why variable numUpdates in PULImpl::mergeUpdateList is declared, assigned > but > > never read? > > Good question :) The easy answer is to just remove it. But I think it can > actually be used to replace the myList.size() in the 2 for loops at lines 1289 > and 1308. Even though new entries can be added in myList during each iteration > of the outer for-loop, I think that during those 2 inner for-loops it is ok to > search myList only up to numUpdates. Do you agree? Yes I agree, the ops in the other PUL cannot conflict with each other. A conflict must be between one of the operation of the first pul and one of the second pul. -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug_872732 into lp:zorba
Stupid question regarding the commit: why are there so many whitespace changes in the diff? -- https://code.launchpad.net/~zorba-coders/zorba/bug_872732/+merge/79272 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug_872732 into lp:zorba
> Stupid question regarding the commit: why are there so many whitespace changes > in the diff? I did not notice that: after installing my machine to Fedora 15 I use a different C++ editor. This one (from CodeBlocks) has a default value to delete the spaces at the end of the line by default. My diff is set to ignore white space differences I did not notice this before the commit. Since this makes a reviewer job more difficult I will set my editor not to delete the spaces before LF. Thanks for reporting this. Best, Sorin -- https://code.launchpad.net/~zorba-coders/zorba/bug_872732/+merge/79272 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
