Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature_fots_driver into lp:zorba
Review: Approve The code looks to be of high quality. I've found one bug (bug 1070704) and made a few enhancement requests to Sorin. I do have a few performance concerns, most particularly with the implementation of the assert-XX functions which create and compile a different query for every comparison. It seems that there might be a more efficient way to do this, such as pre-compiling a single query for each one (on demand) and re-using it for later comparisons by binding different inputs. I admit I don't completely understand what that code is doing and so it may be that this is not possible. However, in my opinion the code is ready to be merged onto the trunk so we can get people to use it, and especially running at least some set of the tests via this driver on the remote queue. This will let us identify any bugs or needed enhancements much more quickly. -- https://code.launchpad.net/~zorba-coders/zorba/feature_fots_driver/+merge/130563 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070551 into lp:zorba
Review: Approve I tested it in sausalito too. Works! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070551/+merge/131099 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-depends into lp:zorba
Review: Needs Fixing As written, DEPENDS will only do anything if the module includes C++ code. If that is sufficient for your needs, fine, but please change the name of the parameter to something like LIBRARY_DEPENDS to make this clear. If you need to have targets executed for modules that do NOT have C++ code, then you may be able to make use of the fifth argument to ADD_COPY_RULE(). However, if you go this route, test it *extensively*; adding target dependencies to CMake custom commands (which is necessary for that to work) often leads to really erratic and frustrating CMake behaviour. It won't even have a chance to work on CMake prior to version 2.8.4, either. I do something similar for DECLARE_ZORBA_JAR(), but it has caused no end of grief and I'm not completely sure it's working right all the time even now. -- https://code.launchpad.net/~zorba-coders/zorba/module-depends/+merge/130784 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1068323 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1068323/+merge/130434 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1068323 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug1068323 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1068323/+merge/130434 -- https://code.launchpad.net/~zorba-coders/zorba/bug1068323/+merge/130434 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1068323 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug1068323-2012-10-24T08-58-48.013Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug1068323/+merge/130434 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-bug1068240 into lp:zorba/xqxq-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqxq-bug1068240/+merge/130867 Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1068323 into lp:zorba
Validation queue job bug1068323-2012-10-24T08-58-48.013Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug1068323/+merge/130434 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1068323 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug1068323 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1068323/+merge/130434 -- https://code.launchpad.net/~zorba-coders/zorba/bug1068323/+merge/130434 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070551 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1070551 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1070551/+merge/131099 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070551/+merge/131099 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070551 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1070551-2012-10-24T11-02-48.674Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070551/+merge/131099 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-depends into lp:zorba
We need the feature to make a module dependent on some header file generation done with zorba. Is the renaming like this ok? -- https://code.launchpad.net/~zorba-coders/zorba/module-depends/+merge/130784 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070551 into lp:zorba
Validation queue job bug-1070551-2012-10-24T11-02-48.674Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070551/+merge/131099 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070551 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1070551 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1070551/+merge/131099 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070551/+merge/131099 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/test-bug-1070551 into lp:zorba/security-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/test-bug-1070551/+merge/131101 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/test-bug-1070551 into lp:zorba/security-module
The proposal to merge lp:~zorba-coders/zorba/test-bug-1070551 into lp:zorba/security-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/test-bug-1070551/+merge/131101 -- https://code.launchpad.net/~zorba-coders/zorba/test-bug-1070551/+merge/131101 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/test-bug-1070551 into lp:zorba/security-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/test-bug-1070551-2012-10-24T11-31-38.275Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/test-bug-1070551/+merge/131101 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/test-bug-1070551 into lp:zorba/security-module
Validation queue job test-bug-1070551-2012-10-24T11-31-38.275Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/test-bug-1070551/+merge/131101 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/test-bug-1070551 into lp:zorba/security-module
The proposal to merge lp:~zorba-coders/zorba/test-bug-1070551 into lp:zorba/security-module has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/test-bug-1070551/+merge/131101 -- https://code.launchpad.net/~zorba-coders/zorba/test-bug-1070551/+merge/131101 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/131166 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/131166 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/131166 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2012-10-24T12-23-01.282Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/131166 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue job markos-scratch-2012-10-24T12-23-01.282Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/131166 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/131166 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/131166 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-bug1068240 into lp:zorba/xqxq-module
The proposal to merge lp:~zorba-coders/zorba/xqxq-bug1068240 into lp:zorba/xqxq-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xqxq-bug1068240/+merge/130867 -- https://code.launchpad.net/~zorba-coders/zorba/xqxq-bug1068240/+merge/130867 Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-bug1068240 into lp:zorba/xqxq-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/xqxq-bug1068240-2012-10-24T15-07-41.913Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/xqxq-bug1068240/+merge/130867 Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-bug1068240 into lp:zorba/xqxq-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqxq-bug1068240/+merge/130867 Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-depends into lp:zorba
No, this naming (and the header comment) still does not convey that this feature is only functional for modules with C++ code. I don't want anyone writing a pure XQuery module to think that this will work for them, because it won't. I still suggestion something like: # LIBRARY_DEPENDS - (optional) A list of targets which the external function library will depend on It's not a great name, but it at least relates it to the LINK_LIBRARIES option which is also only relevant for external function libraries. -- https://code.launchpad.net/~zorba-coders/zorba/module-depends/+merge/130784 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-xqxq-url-resolver into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/zorba-xqxq-url-resolver into lp:zorba has been updated. Commit Message changed to: Change for bug903797: Change to make zorba give the current query's StaticContext when xqxq:prepare-main-module is called. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-xqxq-url-resolver/+merge/123602 -- https://code.launchpad.net/~zorba-coders/zorba/zorba-xqxq-url-resolver/+merge/123602 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/dummy-branch into lp:zorba has been updated. Status: Merged = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/dummy-branch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/dummy-branch into lp:zorba has been updated. Commit Message changed to: Just checking the remote queue with notags=1. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
Chris Hillery has proposed merging lp:~zorba-coders/zorba/dummy-branch into lp:zorba. Commit message: Just checking the remote queue with notags=1. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Just checking the remote queue with notags=1. -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/dummy-branch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/dummy-branch into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/dummy-branch into lp:zorba has been updated. Status: Approved = Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/dummy-branch into lp:zorba has been updated. Status: Rejected = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/dummy-branch-2012-10-24T20-33-43.686Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
Validation queue job dummy-branch-2012-10-24T20-33-43.686Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-branch into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/dummy-branch/+merge/131279 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/dummy-branch into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba has been updated. Commit Message changed to: Moved XQXQ into Zorba core. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295 -- https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba
Review: Approve Conditional approval because everything seems to work. However, the ChangeLog should be updated and an email should be sent to the list letting everybody know that they have to remove xqxq from their zorba_modules directories. -- https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba
I have pushed a ChangeLog change. Tested locally: If I bump the XQXQ version number to 1.1, it can actually co-exist with the non-core module. Should I do this for convenience, or is it better to force people to remove the old one? -- https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba
I have pushed a ChangeLog change. Tested locally: If I bump the XQXQ version number to 1.1, it can actually co- exist with the non-core module. Should I do this for convenience, or is it better to force people to remove the old one? Good question. My feeling is that the old one should be removed because both of the modules provide exactly the same functionality. -- https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba
My feeling is that the old one should be removed because both of the modules provide exactly the same functionality. I tend to agree. Ok, I won't push that change, and I'll send out an email. Juan, please review soon; thanks! -- https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
