Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module
Review: Needs Information 1. Do we need to promote this to version 2.0 of the EXpath module? Isn't the public API exactly the same, as defined by EXpath? I understand the implementation is different, but I don't believe that's relevant for module versioning. 2. (Possibly the same question) Do we need to keep the old version of this module, what we're calling 1.0? Again, they have the same interface, so why would anyone care about importing one or the other? I agree, let us keep the same version. 3. FYI the XQDoc has a link to the scripting tutorial on http://www.zorba- xquery.com/ . That might even be a broken link now, but it should presumably be updated to http://www.zorba.io/ . 4. Also FYI, the example given (reading the Zorba blog RSS feed) almost certainly won't work, since (a) the URL is old and (b) our blog isn't working at the moment. Fixed, will be committed soon. Now that we have updated the core XML HTTP client in zorba to be based on the new core JSON HTTP module there is some code replication here and in the XML HTTP client to convert XML requests into JSON requests and JSON responses in XML responses (600 xquery lines) + error catching and rethrowing. 1) Ignore the replication, (the XML http client will be removed at some point?) 2) Create a non-advertised module for doing the conversions? Are there some best-practices in Zorba? 3) Base the module on the XML http client which is based on the JSON http client (4 conversions for one request) Personally I would go with 1 or 2. Thanks -- https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578 Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module
Is the code replication exact, or very nearly exact? If so I think I'd go with option 2. (If it was only 50-100 lines of code I'd pick option 1, but 600 lines seems like rather a lot.) I suspect that the XML http-client will be with us for quite some time. I agree that option 3, while clean, probably has too much conversion overhead. I'm not sure if there are any best-practices here for implementing #2. As far as I know, there's no real concept of a protected module. For now, just make it a new module in the core with the conversion functions public, and a big XQDoc comment stating that this module isn't intended to be used by anyone other than the two http-client modules and that we make no promises about maintaining the API or the module itself. -- https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578 Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module
Depends on lp:~zorba-coders/zorba/http-client-wrapper -- https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578 Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module
Review: Needs Information 1. Do we need to promote this to version 2.0 of the EXpath module? Isn't the public API exactly the same, as defined by EXpath? I understand the implementation is different, but I don't believe that's relevant for module versioning. 2. (Possibly the same question) Do we need to keep the old version of this module, what we're calling 1.0? Again, they have the same interface, so why would anyone care about importing one or the other? 3. FYI the XQDoc has a link to the scripting tutorial on http://www.zorba-xquery.com/ . That might even be a broken link now, but it should presumably be updated to http://www.zorba.io/ . 4. Also FYI, the example given (reading the Zorba blog RSS feed) almost certainly won't work, since (a) the URL is old and (b) our blog isn't working at the moment. -- https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578 Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578 Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp