The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba/get-name
Validation queue job get-namespace-bindings-2012-01-10T16-00-10.868Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://l
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/get-namespace-bindings-2012-01-10T16-00-10.868Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba/ge
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba/ge
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1.
Got: 1 Approve, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~
Validation queue job get-namespace-bindings-2012-01-10T08-12-08.927Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://l
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/get-namespace-bindings-2012-01-10T08-12-08.927Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba/ge
Review: Approve
I've added a ChangeLog comment.
I did NOT change createElementNode() to accept NsBindings by reference, because
it turns out it's not even a source-compatible change. You can no longer do
things like this to pass "no namespace bindings":
theResponse = theFactory->createElem
> > One more thing. Could we pass the NsBindings parameter as reference without
> > breaking backwards compatibly?
>
> No, at least not for createElementNode(); it would break binary compatibility.
> If you don't mind that, I could make the change - it should still be source-
> compatible, at leas
> One more thing. Could we pass the NsBindings parameter as reference without
> breaking backwards compatibly?
No, at least not for createElementNode(); it would break binary compatibility.
If you don't mind that, I could make the change - it should still be
source-compatible, at least.
> Also
Review: Needs Fixing
One more thing. Could we pass the NsBindings parameter as reference without
breaking backwards compatibly?
Also, before merging, could you please mention the API extension in the
ChangeLog?
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/871
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba/ge
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1.
Got: 1 Approve, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~
Validation queue job get-namespace-bindings-2012-01-06T02-19-10.63Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://la
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/get-namespace-bindings-2012-01-06T02-19-10.63Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba/ge
Review: Approve
Ok, I moved NsBindings to zorba:: scope (in item.h), and changed
createElementNode() to also use it (and clients of createElementNode() to use
it also).
I've changed the usages of createElementNode() in non-core modules as well, but
they compile fine without changes (confirming
> > No, I don't think so. Because the internal NsBindings uses zstring (not
> > zorba::String)
>
> I was talking about the public zorba::ItemFactory::createElementNode() method.
> It takes a std::vector > just like
> getNamespaceBindings() does.
Oh, sorry. Yes, that would make sense.
--
https://c
> No, I don't think so. Because the internal NsBindings uses zstring (not
> zorba::String)
I was talking about the public zorba::ItemFactory::createElementNode() method.
It takes a std::vector > just like
getNamespaceBindings() does.
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespa
> Regarding vector vs. map, after thinking about it a bit, I agree with you that
> map<> would be at least a bit better user experience. However,
> ItemFactory::createElementNode() takes a vector> already, and that
> can't be changed. I think probably it's best that getNamespaceBindings() be
> cons
I've changed to use zorba::store::StoreConsts::NsScoping.
Regarding vector vs. map, after thinking about it a bit, I agree with you that
map<> would be at least a bit better user experience. However,
ItemFactory::createElementNode() takes a vector> already, and that can't
be changed. I think pr
Review: Needs Fixing
Needs Fixing:
include/zorba/store_consts.h already provides an NsScoping enum.
Comment:
An alternative return value could be a map (which is nothing else than an
efficient vector containing pairs).
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba/ge
The attempt to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:273
(message):
Validation queue job get-namespace-bindings-2011-12-31T09-19-06.423Z is
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/get-namespace-bindings-2011-12-31T09-19-06.423Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is requested to review the propos
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba/ge
Chris Hillery has proposed merging
lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba.
Requested reviews:
Zorba Coders (zorba-coders)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Exposes Item::getNamespaceBindings() through
30 matches
Mail list logo
