The proposal to merge lp:~davidagraf/zorba/bug-867248 into
lp:zorba/email-module has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/113059
--
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/113059
Validation queue job bug-867248-2012-07-13T11-05-46.439Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/113059
Your team Zorba Coders is subscribed to branch lp:zorba/email-module.
--
Mailing list: https://launchpad.net
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-867248-2012-07-13T11-05-46.439Z/log.html
--
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/113059
Your team Zorba Coders is subscribed to branch lp:zorba/email-module.
--
Mailin
The proposal to merge lp:~davidagraf/zorba/bug-867248 into
lp:zorba/email-module has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/113059
--
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/
The proposal to merge lp:~davidagraf/zorba/bug-867248 into
lp:zorba/email-module has been updated.
Commit Message changed to:
Fix for bug #867248.
For more details, see:
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/113059
--
https://code.launchpad.net/~davidagraf/zorba/bug-86
Review: Approve
--
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/113059
Your team Zorba Coders is subscribed to branch lp:zorba/email-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net
> I'm afraid I still don't understand what this encoding is doing. It sounds
> like if the subject of an email contains one non-ASCII character, that the
> entire subject line will be encoded as base-64. Is that really the intent?
> Won't that render it completely unreadable in most circumstances?
Thanks for removing the const_casts.
I'm afraid I still don't understand what this encoding is doing. It sounds like
if the subject of an email contains one non-ASCII character, that the entire
subject line will be encoded as base-64. Is that really the intent? Won't that
render it completely u
Review: Approve
--
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/113059
Your team Zorba Coders is subscribed to branch lp:zorba/email-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net
> David - Matthias is on vacation this week, so if possible I'd like to review
> this change instead and get it merged.
>
> That said - can you explain to me the central part of the change, which is the
> Base64 dance done inside of "if (lContainsNonAscii)" ? Better yet, please put
> a comment the
Review: Needs Information
David - Matthias is on vacation this week, so if possible I'd like to review
this change instead and get it merged.
That said - can you explain to me the central part of the change, which is the
Base64 dance done inside of "if (lContainsNonAscii)" ? Better yet, please
Review: Approve
--
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/113059
Your team Zorba Coders is subscribed to branch lp:zorba/email-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net
David Graf has proposed merging lp:~davidagraf/zorba/bug-867248 into
lp:zorba/email-module.
Requested reviews:
David Graf (davidagraf)
For more details, see:
https://code.launchpad.net/~davidagraf/zorba/bug-867248/+merge/113059
Fix for bug #867248.
--
https://code.launchpad.net/~davidagraf/z
13 matches
Mail list logo
