Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-10 Thread Sorin Marian Nasoi
> It's absolutely the same code. > > For the Zorba website, the list of modules and their relationships is cherry > picked and this is done manually. > That's the only difference. The XQDoc code should not require any cherry picking. The structure should be generated using existing information wit

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-10 Thread William Candillon
It's absolutely the same code. For the Zorba website, the list of modules and their relationships is cherry picked and this is done manually. That's the only difference. -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 Your team Zorba Coders is subscribed to branch lp:zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-09 Thread Sorin Marian Nasoi
Review: Needs Fixing William needs to upload the latest version of the 3 new XQDoc modules he created (batch.xq, html.xq and menu.xq) -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://laun

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-04 Thread William Candillon
Just had a look and it looks good. -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpa

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Chris Hillery
I'm afraid there's no way I'm going to be able to give this the review it deserves. Should I request William to review it? -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 You

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
Validation queue job new-xqdoc-2013-04-03T05-16-21.977Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coder

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/new-xqdoc-2013-04-03T05-16-21.977Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Commit Message changed to: New and improved XQDoc. Each module is completely decoupled from one to another and therefore more reusable. This will enable more people like 28msec to reuse this components and i

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 You

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/156731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-code

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 You

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
Validation queue job new-xqdoc-2013-04-03T03-03-11.265Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coder

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/new-xqdoc-2013-04-03T03-03-11.265Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 You

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 You

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job new-xqdoc-2013-04-03T02-21-16.393Z is finished. The final stat

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/new-xqdoc-2013-04-03T02-21-16.393Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Commit Message changed to: New and improved XQDoc. Each module is completely decoupled from one to another and therefore more reusable. This will enable more people like 28msec to reuse this components and i

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 You

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2013-04-02 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/127663 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-code

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-10-05 Thread Sorin Marian Nasoi
Review: Needs Fixing I have managed to create the documentation and the generation is very quick (even after you add all the functionality I still think it will be quicker than the old one). I would have some remarks though: 1) the menu on the left in the modules.html page is broken: here is w

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-10-05 Thread Sorin Marian Nasoi
Review: Needs Fixing > - Regarding the dependency graph, could you please put it back yourself? I was > not able to do it myself as it was highly coupled with the old codebase. It is NOT coupled with the old codebase at all. Just revert all your changes in file doc/zorba/xqdoc/CMakeLists.txt. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-10-03 Thread Sorin Marian Nasoi
> Thanks for the review. > > - I pushed a fix for the build. it is not on the branch yet, right? > - I double checked the @project tag, they all look correct. I change XQDoc to > XQDoc Core to make it more explicit. Sounds OK. > - Regarding Functx.xq, it was my understanding that this would requ

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-10-03 Thread William Candillon
Thanks for the review. - I pushed a fix for the build. - I double checked the @project tag, they all look correct. I change XQDoc to XQDoc Core to make it more explicit. - Regarding Functx.xq, it was my understanding that this would require to update third-party modules manually. Also functx hap

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-09-28 Thread Sorin Marian Nasoi
Review: Disapprove in file doc/zorba/xqdoc/CMakeLists.txt please put back the code for generating the module dependency graph. -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/126382 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.ne

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-09-28 Thread Sorin Marian Nasoi
Review: Needs Fixing 1) @project tags for the following modules are wrong: - modules/com/zorba-xquery/www/modules/node.xq tag Zorba/XQuery Data Model/Node/Node should be Zorba/XQuery Data Model/Node -modules/com/zorba-xquery/www/modules/store/documents/dynamic.xq tag Zorba/Data Store/Documents sh

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-09-28 Thread Sorin Marian Nasoi
Review: Needs Fixing after compiling zorba and running "make xqdoc" I get an error: file {/home/spungi/work/zorba/repo/new-xqdoc/build/xqdoc/generator/xqdoc-xml.xq} not found or not readable. the same error shows for "make doc". -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+mer

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-09-27 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/126382 -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/126382 You

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-09-27 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in ChangeLog text conflict in modules/com/zorba-xquery/www/modules/xqdoc.xq -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/126382 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-09-27 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Commit Message changed to: New and improved XQDoc. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/126382 -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+m

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-09-26 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/126382 -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/126382 You

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-09-25 Thread Matthias Brantner
Review: Needs Information Does this change fix any of the xqDoc-related bugs that are still in the 2.7 milestone: https://launchpad.net/zorba/+milestone/2.7? Just want to make sure I understand the big picture. -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/126313 Your team

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-09-25 Thread William Candillon
I will propose the appropriate @project tag updates on non-core modules. Core and non-core modules have a lot of issues related to their own documentation. I'm gonna propose fixes for these separately. -- https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/126313 Your team Zorba Coder

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-xqdoc into lp:zorba

2012-09-25 Thread William Candillon
The proposal to merge lp:~zorba-coders/zorba/new-xqdoc into lp:zorba has been updated. Commit Message changed to: New and improved XQDoc capabilities. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-xqdoc/+merge/126313 -- https://code.launchpad.net/~zorba-coders/zorba