Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue succeeded - proposal merged! -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Stage ZorbaVQ failed. Check console output at http://jenkins.lambda.nu/job/ZorbaVQ/92/console to view the results. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Commit Message changed to: Changed module's errors to the new modules guidelines; Potential fix for execvpe() on Macs For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module.
Commit message:
Changed module's errors to the new modules guidelines; Potential fix for
execvpe() on Macs
Requested reviews:
Nicolae Brinza (nbrinza)
Ghislain Fourny (gislenius)
Related bugs:
Bug #1188053 in Zorba: Update non-core module process
https://bugs.launchpad.net/zorba/+bug/1188053
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Changed module's errors to the new modules guidelines; Potential fix for
execvpe() on Macs
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
=== modified file 'src/process-2.xq'
--- src/process-2.xq 2013-06-15 19:46:05 +
+++ src/process-2.xq 2013-06-27 14:46:36 +
@@ -26,8 +26,8 @@
: p
: Example:
: pre
- : import module namespace proc = http://zorba.io/modules/process;;
- : proc:exec(ls)
+ : import module namespace p = http://zorba.io/modules/process;;
+ : p:exec(ls)
: /pre
: /p
:
@@ -86,7 +86,7 @@
:
: @return the result of the execution as an object
:
- : @error p:PROC01 if an error occurred while communicating with the process.
+ : @error p:COMMUNICATION if an error occurred while communicating with the process.
:)
declare %an:sequential function p:exec(
$filename as string
@@ -113,7 +113,7 @@
:
: @return the result of the execution as an object
:
- : @error p:PROC01 if an error occurred while communicating with the process.
+ : @error p:COMMUNICATION if an error occurred while communicating with the process.
:)
declare %an:sequential function p:exec(
$filename as string,
@@ -147,7 +147,7 @@
:
: @return the result of the execution as an object
:
- : @error p:PROC01 if an error occurred while communicating with the process.
+ : @error p:COMMUNICATION if an error occurred while communicating with the process.
:)
declare %an:sequential function p:exec(
$filename as string,
@@ -168,7 +168,7 @@
:
: @return the result of the execution as an object
:
- : @error p:PROC01 if an error occurred while communicating with the process.
+ : @error p:COMMUNICATION if an error occurred while communicating with the process.
:)
declare %an:sequential function p:exec-command(
$cmd as string
@@ -189,7 +189,7 @@
:
: @return the result of the execution as an object
:
- : @error p:PROC01 if an error occurred while communicating with the process.
+ : @error p:COMMUNICATION if an error occurred while communicating with the process.
:)
declare %an:sequential function p:exec-command(
$cmd as string,
=== modified file 'src/process-2.xq.src/process.cpp'
--- src/process-2.xq.src/process.cpp 2013-06-21 03:37:04 +
+++ src/process-2.xq.src/process.cpp 2013-06-27 14:46:36 +
@@ -51,12 +51,21 @@
#ifndef WIN32
int execvpe(const char *program, char **argv, char **envp)
{
+ TREE
extern char **environ;
char **saved = environ;
int rc;
environ = envp;
rc = execvp(program, argv);
environ = saved;
+===
+ clearenv();
+ int i = 0;
+ while (envp[i] != NULL)
+putenv(envp[i++]);
+
+ int rc = execvp(program, argv);
+ MERGE-SOURCE
return rc;
}
#endif
@@ -105,8 +114,7 @@
wsprintf(lErrorBuffer,TEXT(Process Error Code: %d - Message= %s),GetLastError(), (TCHAR *)lpvMessageBuffer);
LocalFree(lpvMessageBuffer);
Item lQName = ProcessModule::getItemFactory()-createQName(
-http://www.zorba-xquery.com/modules/process;,
-PROC01);
+http://zorba.io/modules/process;, COMMUNICATION);
#ifdef UNICODE
char error_str[1024];
WideCharToMultiByte(CP_UTF8, 0, lErrorBuffer, -1, error_str, sizeof(error_str), NULL, NULL);
@@ -239,7 +247,7 @@
|| !CreatePipe(lErrRead,lStdErr,lSecurityAttributes,1024*1024) // std::cerr lErrRead
){
Item lQName = ProcessModule::getItemFactory()-createQName(
- http://www.zorba-xquery.com/modules/process;, PROC01);
+ http://zorba.io/modules/process;, COMMUNICATION);
throw USER_EXCEPTION(lQName,
Couldn't create one of std::cout/std::cerr pipe for child process execution.
);
@@ -261,7 +269,7 @@
lErrorMsg
Couldn't get exit code from child process. Executed command: ' aCommand '.;
Item lQName = ProcessModule::getItemFactory()-createQName(
-http://www.zorba-xquery.com/modules/process;, PROC01);
+http://zorba.io/modules/process;, COMMUNICATION);
throw USER_EXCEPTION(lQName, lErrorMsg.str().c_str());
}
@@ -451,7 +459,7 @@
std::stringstream lErrorMsg;
lErrorMsg Failed to execute the command ( code );
Item lQName = ProcessModule::getItemFactory()-createQName(
- http://www.zorba-xquery.com/modules/process;, PROC01);
+ http://zorba.io/modules/process;, COMMUNICATION);
throw USER_EXCEPTION(lQName, lErrorMsg.str().c_str());
}
exit_code = code;
@@ -489,7 +497,7 @@
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Attempt to merge into lp:zorba/process-module failed due to conflicts: text conflict in src/process-2.xq.src/process.cpp -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-06-27T15-10-41.002Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue job process-2-2013-06-27T15-10-41.002Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-06-13T10-31-56.151Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The attempt to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job process-2-2013-06-13T10-31-56.151Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
FYI, you're going to need to merge changes from lp:zorba/process-module in order for the build to succeed. Paul's been moving #include files around on the Zorba trunk which affects many non-core modules. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
I've merged Paul's change -- it was only a one line change. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-06-13T11-03-45.577Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue job process-2-2013-06-13T11-03-45.577Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Approve I made some final changes, i.e. moved the files and improved the documentation. Concerning me, it's ready to go. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
For some reason, the commits to my checked-out branch are not pushed automatically, and I forgot to do it manually. It is pushed now. I've also fixed all issues you reported except for the namespace change to zorba.io. As far as I understood, it will be done for all modules at once -- it is better than changing the namespace for one module at random, so I think it can be merged now with the current namespace. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Matthias, They URI messages won't appear anymore, but I've done it by calling abort() instead of exit() in the child fork() in the process module, because: -- it will keep the Zorba URIs leaks messages in the Release build -- the exit code in the case of an error is lost anyway due to the thrown exception in Zorba -- it is not actually correct to deallocate the Zorba store twice (once in the child and the second time in the parent). It could lead to problems if store is not an in-memory store. I've added a lengthy comment in the code describing what happens and where the problem lies. If the error exit code could be sent to the main process (e.g. through another opened pipe) then it would work perfectly. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Needs Fixing - I didn't see the changes you described in the last comment. Did you not push them? - Why does the module use XQuery instead of JSONiq? I think it should use JSONiq and not use prefixes for types etc. - we might have to change the namespace to zorba.io - comments should use p to separate paragraphs instead of newlines. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-27T14-21-35.131Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
I've fixed all the issues except for the leaks problem. I have not removed the printing of the URIs because it would disable them for the entire Zorba engine. Even if the messages are removed there is still the problem of the exit code, which cannot be fixed easily now. -- -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue job process-2-2013-05-27T14-21-35.131Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1 Approve, 1 Needs Fixing. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Let's not worry about the leaks for now. Instead, we should simply disable the debug output printing the referenced uris. I think we should bring the init/shutdown problem to the Zorba team. This has been bothering us and others for quite some time. Zorba 3.0 is the only time to fix this. Could you please fix the other comments (especially, the v2 issue)? -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Regarding the referenced URI messages -- these are indeed coming from the StringPool as leaked entries. When the main process is fork()'ed, the child process is basically a copy of the parent process with all the statically allocated objects duplicated. When the child process calls exit(), those objects are destroyed. Since Zorba doesn't go through a normal shutdown, the StringPool still contains those entries and it prints the error messages and even throws an error. As a result the exit code of the process that was executed is actually lost. Even if the StringPool errors are bypassed somehow, another error is raised in the Lock() class. This problem was present in 1.0 version as well. The root of the problem is the bad design of engine and store instantiation: they are static singletons which require explicit calls to shutdown. Some possible solutions are: 1) Call abort() instead of exit() -- this will bypass all the static object destruction but I will need to find a way to pass the exit code to the parent process. 2) Pass the engine and store pointers to the process module and down to the child process so that it can call shutdown on them. This has the added problem of shutting down the store twice -- it is not an issue for an in-memory store, but could be for other stores. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module.
Commit message:
Version 2.0 of the process module, allows running executables directly, without
invoking bash/cmd.exe
Requested reviews:
Nicolae Brinza (nbrinza)
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Version 2.0 of the process module, allows running executables directly, without
invoking bash/cmd.exe
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
=== modified file 'src/com/zorba-xquery/www/modules/CMakeLists.txt'
--- src/com/zorba-xquery/www/modules/CMakeLists.txt 2011-07-01 09:24:09 +
+++ src/com/zorba-xquery/www/modules/CMakeLists.txt 2013-05-17 12:29:26 +
@@ -12,4 +12,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-DECLARE_ZORBA_MODULE (URI http://www.zorba-xquery.com/modules/process; VERSION 1.0 FILE process.xq)
+DECLARE_ZORBA_MODULE (URI http://www.zorba-xquery.com/modules/process; VERSION 2.0 FILE process.xq)
=== modified file 'src/com/zorba-xquery/www/modules/process.xq'
--- src/com/zorba-xquery/www/modules/process.xq 2012-12-06 02:13:28 +
+++ src/com/zorba-xquery/www/modules/process.xq 2013-05-17 12:29:26 +
@@ -28,14 +28,17 @@
:
: Potential result:
: pre class=ace-static ace-mode=xquery![CDATA[
- : result xmlns=http://www.zorba-xquery.com/modules/process;
- : stdoutmyfile.txt/stout
- : stderr/
- : exit-code0/exit-code
- : /result
+ : {
+ : exit-code: 0,
+ : stdout: myfile.txt,
+ : stderr:
+ : }
: ]]/pre
:
- : @author Cezar Andrei
+ : The exec-command() set of functions allows execution of commands through the operating
+ : system's command line interpreter, such as sh on Linux or cmd.exe on Windows.
+ :
+ : @author Cezar Andrei, Nicolae Brinza
: @project Zorba/IO/Process
:
:)
@@ -44,7 +47,100 @@
declare namespace an = http://www.zorba-xquery.com/annotations;;
declare namespace ver = http://www.zorba-xquery.com/options/versioning;;
-declare option ver:module-version 1.0;
+declare option ver:module-version 2.0;
+
+
+(:~
+ : Executes the specified program in a separate process.
+ : This function does not allow arguments to be passed to
+ : the command. The $filename parameter can contain the full path to the
+ : executable. On Linux systems, if the specified filename does not contain
+ : a slash /, the function duplicates the actions of the shell in searching
+ : for an executable file. The file is sought in the colon-separated list of
+ : directory pathnames specified in the PATH environment variable. If this
+ : variable isn't defined, the path list defaults to the current directory
+ : followed by the list of directories returned by the operating system.
+ :
+ : @param $filename the name of program to be executed
+ :
+ : @return the result of the execution as an object as
+ : shown in the documentation of this module. The exit-code
+ : returns the exit code of the child process.
+ : For POSIX compliant platforms: returns the program exit code. If the program is
+ : terminated or stopped: 128 + termination signal code.
+ : For Windows platforms: returns the return value of the program or the exit
+ : or terminate process specified value.
+ :
+ : @error process:PROC01 if an error occurred while communicating
+ : with the executed process.
+ :)
+declare %an:sequential function process:exec(
+ $filename as xs:string
+) as object() external;
+
+(:~
+ : Executes the specified program in a separate process.
+ : The $filename parameter can contain the full path to the
+ : executable. On Linux systems, if the specified filename does not contain
+ : a slash /, the function duplicates the actions of the shell in searching
+ : for an executable file. The file is sought in the colon-separated list of
+ : directory pathnames specified in the PATH environment variable. If this
+ : variable isn't defined, the path list defaults to the current directory
+ : followed by the list of directories returned by the operating system.
+ : The $args parameters will be passed to the executable file as arguments.
+ :
+ : @param $filename the name of program to be executed
+ : @param $args arguments to be passed to the executable
+ :
+ : @return the result of the execution as an object as
+ : shown in the documentation of this module. The exit-code
+ : returns the exit code of the child process.
+ : For POSIX compliant platforms: returns the program exit code. If the program is
+ : terminated or stopped: 128 + termination signal code.
+ : For Windows platforms: returns the return value of the program or the exit
+ : or terminate process specified value.
+ :
+ : @error process:PROC01 if an error occurred while communicating
+ : with the executed process.
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T12-29-40.913Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The attempt to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job process-2-2013-05-17T12-29-40.913Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T13-03-41.447Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The attempt to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job process-2-2013-05-17T13-03-41.447Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T13-34-44.754Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The attempt to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job process-2-2013-05-17T13-34-44.754Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T13-53-40.588Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The attempt to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job process-2-2013-05-17T13-53-40.588Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T14-27-39.824Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The attempt to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job process-2-2013-05-17T14-27-39.824Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T14-42-40.749Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The attempt to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job process-2-2013-05-17T14-42-40.749Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module.
Commit message:
Version 2.0 of the process module, allows running executables directly, without
invoking bash/cmd.exe
Requested reviews:
Nicolae Brinza (nbrinza)
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Version 2.0 of the process module, allows running executables directly, without
invoking bash/cmd.exe
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
=== modified file 'src/com/zorba-xquery/www/modules/CMakeLists.txt'
--- src/com/zorba-xquery/www/modules/CMakeLists.txt 2011-07-01 09:24:09 +
+++ src/com/zorba-xquery/www/modules/CMakeLists.txt 2013-05-17 14:50:32 +
@@ -12,4 +12,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-DECLARE_ZORBA_MODULE (URI http://www.zorba-xquery.com/modules/process; VERSION 1.0 FILE process.xq)
+DECLARE_ZORBA_MODULE (URI http://www.zorba-xquery.com/modules/process; VERSION 2.0 FILE process.xq)
=== modified file 'src/com/zorba-xquery/www/modules/process.xq'
--- src/com/zorba-xquery/www/modules/process.xq 2012-12-06 02:13:28 +
+++ src/com/zorba-xquery/www/modules/process.xq 2013-05-17 14:50:32 +
@@ -28,14 +28,17 @@
:
: Potential result:
: pre class=ace-static ace-mode=xquery![CDATA[
- : result xmlns=http://www.zorba-xquery.com/modules/process;
- : stdoutmyfile.txt/stout
- : stderr/
- : exit-code0/exit-code
- : /result
+ : {
+ : exit-code: 0,
+ : stdout: myfile.txt,
+ : stderr:
+ : }
: ]]/pre
:
- : @author Cezar Andrei
+ : The exec-command() set of functions allows execution of commands through the operating
+ : system's command line interpreter, such as sh on Linux or cmd.exe on Windows.
+ :
+ : @author Cezar Andrei, Nicolae Brinza
: @project Zorba/IO/Process
:
:)
@@ -44,7 +47,100 @@
declare namespace an = http://www.zorba-xquery.com/annotations;;
declare namespace ver = http://www.zorba-xquery.com/options/versioning;;
-declare option ver:module-version 1.0;
+declare option ver:module-version 2.0;
+
+
+(:~
+ : Executes the specified program in a separate process.
+ : This function does not allow arguments to be passed to
+ : the command. The $filename parameter can contain the full path to the
+ : executable. On Linux systems, if the specified filename does not contain
+ : a slash /, the function duplicates the actions of the shell in searching
+ : for an executable file. The file is sought in the colon-separated list of
+ : directory pathnames specified in the PATH environment variable. If this
+ : variable isn't defined, the path list defaults to the current directory
+ : followed by the list of directories returned by the operating system.
+ :
+ : @param $filename the name of program to be executed
+ :
+ : @return the result of the execution as an object as
+ : shown in the documentation of this module. The exit-code
+ : returns the exit code of the child process.
+ : For POSIX compliant platforms: returns the program exit code. If the program is
+ : terminated or stopped: 128 + termination signal code.
+ : For Windows platforms: returns the return value of the program or the exit
+ : or terminate process specified value.
+ :
+ : @error process:PROC01 if an error occurred while communicating
+ : with the executed process.
+ :)
+declare %an:sequential function process:exec(
+ $filename as xs:string
+) as object() external;
+
+(:~
+ : Executes the specified program in a separate process.
+ : The $filename parameter can contain the full path to the
+ : executable. On Linux systems, if the specified filename does not contain
+ : a slash /, the function duplicates the actions of the shell in searching
+ : for an executable file. The file is sought in the colon-separated list of
+ : directory pathnames specified in the PATH environment variable. If this
+ : variable isn't defined, the path list defaults to the current directory
+ : followed by the list of directories returned by the operating system.
+ : The $args parameters will be passed to the executable file as arguments.
+ :
+ : @param $filename the name of program to be executed
+ : @param $args arguments to be passed to the executable
+ :
+ : @return the result of the execution as an object as
+ : shown in the documentation of this module. The exit-code
+ : returns the exit code of the child process.
+ : For POSIX compliant platforms: returns the program exit code. If the program is
+ : terminated or stopped: 128 + termination signal code.
+ : For Windows platforms: returns the return value of the program or the exit
+ : or terminate process specified value.
+ :
+ : @error process:PROC01 if an error occurred while communicating
+ : with the executed process.
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Commit Message changed to: Version 2.0 of the process module, allows running executables directly, without invoking bash/cmd.exe For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T14-50-41.743Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The attempt to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job process-2-2013-05-17T14-50-41.743Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T15-29-41.901Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Validation queue job process-2-2013-05-17T15-29-41.901Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module
Review: Needs Fixing
- I like the signatures and the documentation
- The two modules should both live in the same branch process (subdirectories
process/v1 and process/v2) for the versioning to work the v2 one needs to be
added first and then the v1 one. If we don't want to change all of our
infrastructure immediately, we need to have both versions installed.
- update license header to 2013
- create_result_node(...) in process.cpp is not used anymore
- such as sh on Linux or cmd.exe on Windows. = such as sh on Unix or
cmd.exe on Windows.
- import module namespace process =
http://www.zorba-xquery.com/modules/process;;
process:exec(export, , foo=bar)
gives me
{
exit-code : 139,
stdout : ,
stderr : execl: No such file or directory\nID: 80 Referenced URI:
http://www.zorba-xquery.com/modules/process\nID: 94 Referenced URI:
http://www.zorba-xquery.com/options/versioning\n;
}
- the referenced uri message seems to be related to a memory leak
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
