Chris Hillery has proposed merging lp:~zorba-coders/zorba/fots-notice into
lp:zorba.
Commit message:
Added attribution to BaseX for initial inspiration of the FOTS driver.
Requested reviews:
Zorba Coders (zorba-coders)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fots
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fots-notice/+merge/136872
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-co
>> - why do we need to pop the entire stack in the destructor of the loader
>> (shouldn't it be always empty)?
>
> It won't be empty if an exception is thrown.
Makes sense.
>
>> - can the huge number of catch clauses in the loader be reduced by only
>> catching a base class without loss of seman
> > Actually, I was going to open another bug after this was merged (since the
> bug existed before my changes). The old (and still current) code catches the
> exception and throws a new exception passing the existing what() message --
> that's wrong since the what() message from the json::* excep
BTW: as I mentioned in the other bug, I couldn't reproduce the error (at least
it never dumped core) on Mac OS X, so I have no idea whether your/our patch
fixed the bug or not.
--
https://code.launchpad.net/~paul-lucas/zorba/feature-json_strip_array/+merge/136826
Your team Zorba Coders is subscr
I stand corrected: the English-only issue was of my own making. It's now fixed.
--
https://code.launchpad.net/~paul-lucas/zorba/feature-json_strip_array/+merge/136826
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba
Review: Needs Fixing
I have done some testing and discovered a memory leak. Essentially, the memory
isn't released as the stream is processed. Specifically, the memory allocated
in json_loader.cpp:46 and json_loader.cpp:49 is never released.
--
https://code.launchpad.net/~paul-lucas/zorba/featu
OK, I fixed the memory leak.
--
https://code.launchpad.net/~paul-lucas/zorba/feature-json_strip_array/+merge/136826
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://l
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/feature-json_strip_array/+merge/136826
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.ne
9 matches
Mail list logo
