As noted, this change as it stands is not acceptable. Marking proposal as
Rejected.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/144762
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/bug1073175 into lp:zorba has been
updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/144762
--
https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/144762
Juan Zacarias has proposed merging lp:~zorba-coders/zorba/bug1073175 into
lp:zorba with lp:~paul-lucas/zorba/feature-utf8_streambuf as a prerequisite.
Requested reviews:
Sorin Marian Nasoi (sorin.marian.nasoi)
Chris Hillery (ceejatec)
Paul J. Lucas (paul-lucas)
Related bugs:
Bug #1073175
Review: Needs Fixing
You still have + TREE merge-proposal cruft in the files.
You shouldn't catch all exceptions with (...) but only exceptions that either
ios or I throw (from the utft::streambuf).
--
https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/144762
Your team Zorba
Suggestion about fixing the conflict in the cli.xq:
- bzr revert cli.xq
- bzr merge lp:zorba bzr commit
- remove the line with fn:unparsed-text-lines-xxx failing test
- bzr commit
- bzr push
--
https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/144762
Your team Zorba Coders is
As a quick note: The TREE stuff is not actually in the branch. That's
how Launchpad displays diffs here on the website when there is a merge conflict.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/144762
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Review: Approve
I believe the changes look OK. However, I don't quite understand the issue
being checked for here, so I've asked Paul to review as well.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/136488
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Review: Needs Fixing
Calling getStringValue() on a streamable string (as you do in order to validate
it) materializes the entire string -- that defeats the purpose of having a
streaming string in the first place.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/136488
Your
Ahh, duh. Sorry I missed that.
So what is the correct way to check a streamable string? Presumably the check
has to be done while streaming...
--
https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/136488
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
So what is the correct way to check a streamable string? Presumably the check
has to be done while streaming...
I think the user of the streamable string has to do the checking, i.e., if
getStream() is called, then whoever is reading said stream has to do it -- the
StreamableString can't do
Review: Needs Fixing
OK, I'm afraid I guess I don't know enough about the problem to know which
solution is best. Sorin, please work with Paul to determine how (and if) it
might be possible to implement this function without breaking streamability.
Paul can probably provide a method to allow
Juan Zacarias has proposed merging lp:~zorba-coders/zorba/bug1073175 into
lp:zorba.
Commit message:
Fix for bug 1073175.
Changes to fn:unparsed-text, fn:unparsed-text-available and
fn:unparsed-text-lines.
They now throw the correct error when the input contains unsupported utf-8
characters
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug1073175/+merge/136488
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
13 matches
Mail list logo
