The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-i
Validation queue job xml-in-json-indices-2013-02-21T15-43-09.091Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launch
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2013-02-21T15-43-09.091Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
Hi Paul,
I formerly assessed the risk of reaching the limits of the int/long range for a
position as highly unlikely, but I do have doubts about whether a negative
number might go through. So I changed assert(false) to a proper processor
exception. I also changed to const&.
--
https://code.lau
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 4 Approve, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job xml-in-json-indices-2013-02-21T14-37-15.369Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launch
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2013-02-21T14-37-15.369Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 4 Approve, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job xml-in-json-indices-2013-02-18T16-14-00.593Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launch
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2013-02-18T16-14-00.593Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 4 Approve, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job xml-in-json-indices-2013-02-18T15-20-10.215Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launch
> Do the changes fulfil your expectations provided all tests pass?
No because you should catch by const& not by value. And is "assert(false)"
really the only/best thing you can do? Is there any legitimate way the
position can exceed the size of a long? If the answer is "yes," then you need
t
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2013-02-18T15-20-10.215Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
I just noticed you are in a Need Fixing state, so I am pushing to the patch
queue.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorb
Good catch Paul. Do the changes fulfil your expectations provided all tests
pass? I am not pushing yet to the patch queue because it might get through
without your approval.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed t
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
In several places, I see calls to to_xs_unsignedInt() and to
to_xs_unsignedLong() without catching the possible std::range_error.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https:/
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 2 Approve, 2 Needs Fixing, 1 Needs
Information.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch l
Validation queue job xml-in-json-indices-2013-02-07T14-13-01.44Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchp
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2013-02-07T14-13-01.44Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Description changed to:
1. Introducing StructuredItem interface and CollectionTreeInfo class to manage
interactions between trees (of JSON and/or XML nodes) and collections.
2. Extending the use of
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Commit Message changed to:
1. Introducing StructuredItem interface and CollectionTreeInfo class to manage
interactions between trees (of JSON and/or XML nodes) and collections.
2. Extending the use
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 4 Needs Fixing, 1 Needs Information.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Validation queue job xml-in-json-indices-2013-02-04T15-47-42.372Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launch
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2013-02-04T15-47-42.372Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Validation queue job xml-in-json-indices-2013-01-30T14-46-35.086Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launch
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 4 Needs Fixing, 1 Needs Information.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2013-01-30T14-46-35.086Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in src/store/naive/simple_collection.cpp
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zo
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 4 Needs Fixing, 1 Needs Information.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Validation queue job xml-in-json-indices-2013-01-29T13-59-36.602Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launch
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2013-01-29T13-59-36.602Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The attempt to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job xml-in-json-indices-2013-01-29T10-15-10.37Z is
finish
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2013-01-29T10-15-10.37Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 4 Needs Fixing, 1 Needs Information.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Validation queue job xml-in-json-indices-2012-12-14T12-50-24.017Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launch
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2012-12-14T12-50-24.017Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
> > It's because it adds them to the XCode project. Not having them makes full-
> > text search very cumbersome (i.e., headers are not considered).
>
> Isn't that what our own HEADER_GROUP_SUBFOLDER custom macro is for?
Thanks for the pointer. I removed the .h files for now and will address this
> Why is the isStructuredItem() method a virtual one? I don't think it needs to
> be.
Nice catch, I made it non-virtual.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpa
> In XmlTree, there are now 2 pointers to the root node of the tree: theRootNode
> and theTreeInfo->theRoot.
> Also, theTreeInfo should be an embeded instance of CollectionTreeInfo, instead
> of being allocated every time an XmlTree is constructed.
>
> There is already an Item::isInSubtreeOf() met
> And I have one more question: an XML tree can have a tree ID even
> if it is not in a collection. The tree id is used in the construction of
> structural references, and maybe in other places that I don't remember right
> now. In your merge proposal I see that the tree id is changed when a tree i
> It's because it adds them to the XCode project. Not having them makes full-
> text search very cumbersome (i.e., headers are not considered).
Isn't that what our own HEADER_GROUP_SUBFOLDER custom macro is for?
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Y
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 4 Needs Fixing, 1 Needs Information.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Validation queue job xml-in-json-indices-2012-12-12T11-47-09.52Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchp
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2012-12-12T11-47-09.52Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in src/store/naive/CMakeLists.txt
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-cod
I will also investigate the other two remarks, which make sense to me
(isSubtreeOf, tree ID when not in a collection).
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.
Hi Markos,
Thanks for your thorough analysis.
> Also, theTreeInfo should be an embeded instance of CollectionTreeInfo,
> instead of being allocated every time an XmlTree is constructed.
> But I still don't see why a CollectionTreeInfo must be heap-allocated
> every time an XmlTree is constructed
> In detachFromCollection(), you declare a local TreeId. A TreeId is currently
> defined as a typedef for a ulong. Defining a local variable of a C++ built-in
> type does no initialization, so the value of lTreeId is garbage.
This is now fixed. Actually, the variable would not have been used, bu
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
> Why are .h files listed in the CMakefiles? You don't need to do that. The
> CMake system figures out the .h dependences from the specified .cpp files.
> Remove the .h dependencies.
Hi Paul,
It's because it adds them to the XCode project. Not having them makes full-text
search very cumbersome
Sorry, Ghislain, I did not see Mathias questions and your answers. Now I
understand why there 2 root pointers. But I still don't see why a
CollectionTreeInfo must be heap-allocated every time an XmlTree is constructed.
And I have one more question: an XML tree can have a tree ID even if it is no
Review: Needs Fixing
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.
In XmlTree, there are now 2 pointers to the root node of the tree: theRootNode
and theTreeInfo->theRoot.
Also, theTreeInfo should be an embeded instance of CollectionTreeInfo, instead
of being allocated every time an XmlTree is constructed.
There is already an Item::isInSubtreeOf() method at the
Why is the isStructuredItem() method a virtual one? I don't think it needs to
be.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorb
Review: Needs Fixing
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.
In detachFromCollection(), you declare a local TreeId. A TreeId is currently
defined as a typedef for a ulong. Defining a local variable of a C++ built-in
type does no initialization, so the value of lTreeId is garbage.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+mer
Why are .h files listed in the CMakefiles? You don't need to do that. The
CMake system figures out the .h dependences from the specified .cpp files.
Remove the .h dependencies.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscr
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Needs Fixing, 1 Needs Information.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Validation queue job xml-in-json-indices-2012-11-09T13-57-20.423Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launch
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2012-11-09T13-57-20.423Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Hi Till,
Good catch, it was a double free. Only Linux complained about it. Thanks! It
should be fixed now, rerunning the tests.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Review: Needs Fixing
When running foaf-json-xml-index-point-maintenance.xq I run into a memory
problem:
==13041== Invalid read of size 8
==13041==at 0x5ED4C32:
zorba::simplestore::CollectionTreeInfo::getCollection() const
(collection_tree_info.h:54)
==13041==by 0x5EC3C45:
zorba::simpl
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Needs Fixing, 1 Needs Information.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Validation queue job xml-in-json-indices-2012-09-12T14-39-42.74Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchp
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2012-09-12T14-39-42.74Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
1 - 100 of 128 matches
Mail list logo
