Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/find-icu-version/+merge/103197
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zor
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 2 Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/find-icu-version/+merge/103197
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: ht
Looking in either header file now.
--
https://code.launchpad.net/~zorba-coders/zorba/find-icu-version/+merge/103197
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://l
I have no idea about finding the path to icu-config. I suppose try to read
uvernum.h first -- if that fails, read uversion.h.
--
https://code.launchpad.net/~zorba-coders/zorba/find-icu-version/+merge/103197
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launc
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 2 Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/find-icu-version/+merge/103197
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: ht
Well, that's annoying. The comment in uvernum.h said that the #define was
"stable" since 2.4, but I guess that doesn't include the file it's defined in.
I didn't use icu-config because the existing FindICU.cmake doesn't find the
executables, only the include files and libraries. I don't know eno
Older ICU versions don't have the uvernum.h header -- they used to use (just)
uversion.h. Hence, your patch won't work on older versions (including 3.8.1
which is what the remote queue machine is running) which kind of defeats the
point.
Why not use the icu-config --version command?
--
https:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/find-icu-version/+merge/103197
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zor
8 matches
Mail list logo