Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-cod
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://
The attempt to merge lp:~zorba-coders/zorba/fn_envvars into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job fn_envvars-2012-04-13T10-25-07.592Z is finished. The
final st
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-cod
all changes done
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coder
Regarding point 2: Remember that the StreamReleaser and the istream must always
be kept together as a pair, and the StreamReleaser must be the only way that
you clean up the istream. Here, you are deleting the istream directly (bad),
and by setting the StreamReleaser on theStreamResource to null
Review: Needs Fixing
- There seems to be a merge conflict.
- The stream stored in the state must be deleted using the streamReleaser
- The lErrorMessage stream is passed as parameter but the errors only take one
parameter.
- The LoadProperties are not used anywhere
- The following can be simplifi
Errors are Fixed
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coder
> > - the unparsed-text-lines function doesn't really stream because it
> > materializes all the lines in a vector before returning them. Instead, the
> > iterator should keep the istream in it's state and return the lines as they
> > are parsed from the stream.
> Just one question about this, the
> - the unparsed-text-lines function doesn't really stream because it
> materializes all the lines in a vector before returning them. Instead, the
> iterator should keep the istream in it's state and return the lines as they
> are parsed from the stream.
Just one question about this, the Item retur
Review: Needs Fixing
- the unparsed-text-lines function doesn't really stream because it
materializes all the lines in a vector before returning them. Instead, the
iterator should keep the istream in it's state and return the lines as they are
parsed from the stream.
- the two readDocument func
the errors mentioned should be solved now.
let me know if there is any other thing to be changed before merging.
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
I ran
ctest -R xquery_3_0
on this branch, and:
- the following functions from F&O 3.0 spec are still not implemented:
filter#2 fold-left#3 fold-right#3 function-lookup#2 map#2 map-pairs#3
parse-xml-fragment#1 unparsed-text-lines#1 unparsed-text-lines#2 has-children#0
nilled#0 path#0 path#1
- th
> > > - It's unclear when the original stream for unparsed-text is released.
> This
> > > seems to be a memory leak.
> > for the original stream of unparsed-text which variable you mean?
> Yes, the stream you receive from the StreamResource contains a stream which is
> wrapped into a streamable str
> > - It's unclear when the original stream for unparsed-text is released. This
> > seems to be a memory leak.
> for the original stream of unparsed-text which variable you mean?
Yes, the stream you receive from the StreamResource contains a stream which is
wrapped into a streamable string. The st
> - It's unclear when the original stream for unparsed-text is released. This
> seems to be a memory leak.
for the original stream of unparsed-text which variable you mean?
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:z
> I will make all those changes, Thanks.
>
> and answering your questions
>
> > - you can check using transcode::is_necessary if a encoding is supported
> If I am not wrong I am using it that way.
My bad, I meant transcode::is_supported should be used.
> > > - What's the default encoding for unp
I will make all those changes, Thanks.
and answering your questions
> - you can check using transcode::is_necessary if a encoding is supported
If I am not wrong I am using it that way.
> - What's the default encoding for unparsed-text?
UTF-8
The thing with the encoding is that the encoding is d
Review: Needs Fixing
- dynamic_context::get_environment_variable(const zstring varname)
should be
dynamic_context::get_environment_variable(const zstring& varname)
- spaces before "(". for example "if (...) instead of if(...)"
- all new functions in sequences_impl.cpp are indented with two spa
> I'm not entirely sure but the diff now only shows whitespace differences in
> generated files. I didn't find any change which adds one of the new functions.
The diff below just show the diff for the errors in which the error codes
FOUT1170 and FOUT1190 where added the diffs for the implementati
Review: Needs Information
I'm not entirely sure but the diff now only shows whitespace differences in
generated files. I didn't find any change which adds one of the new functions.
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to b
> Why did you delete NOTICE.txt?
I am not really sure why that happened but it should be there now
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is requested to review the proposed merge of
lp:~zorba-coders/zorba/fn_envvars into lp:zorba.
--
Ma
Why did you delete NOTICE.txt?
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is requested to review the proposed merge of
lp:~zorba-coders/zorba/fn_envvars into lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-
23 matches
Mail list logo
