Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94494 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94494 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94494 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba
> include/zorba/item.h: Docs do not say what happens, if > getBase64BinaryValue is called when the item is streamable. fixed > > include/zorba/item_factory.h: "whence" isn't the most commonly used word > (http://en.wiktionary.org/wiki/whence) maybe we could use another one fixed (although the comment was originally written by a native speaker ;-) > > src/runtime/base64/base64_impl.cpp:43 is it ok to ignore the result of > consumeNext because the input can't be an empty sequence? If so, should > we add a comment? this is common practice in almost every iterator. It's not possible that consumeNext returns false if the sequence-type of the function doesn't allow the empty sequence. > > Could we implement Base64BinaryItem::getStringValue() using > Base64BinaryItem::getStringValue2(zstring& val)? done > > Does Base64BinaryItem::getStringValue2(zstring& val) work if val is not > empty? It seems that theValue would be prepended to the current content > of val. Could we implement this method by emptying val and calling > Base64BinaryItem::appendStringValue on it? fixed & done > StreamableBase64BinaryItem::materialize(): > - Is there a reason for the number 4048? no - I have no idea what the best value would be > - In general those might be a lot of re-allocations, if the item is a > little larger (e.g. if the item is 1MB, we've got more than 250 > re-allocations). I'm not sure where the right trade-off is, but it > seems that this parameter might become expensive (if someone > materializes a large item that should be streamed …) Yes, it's really expensive if the stream is not seekable. The situation is much better if the stream is seekable but I have no idea how to improve the materialize if not. > > I just hope that src/zorbaserialization/zorba_class_serializer.cpp works. me too -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94081 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba
Review: Approve include/zorba/item.h: Docs do not say what happens, if getBase64BinaryValue is called when the item is streamable. include/zorba/item_factory.h: "whence" isn't the most commonly used word (http://en.wiktionary.org/wiki/whence) maybe we could use another one src/runtime/base64/base64_impl.cpp:43 is it ok to ignore the result of consumeNext because the input can't be an empty sequence? If so, should we add a comment? Could we implement Base64BinaryItem::getStringValue() using Base64BinaryItem::getStringValue2(zstring& val)? Does Base64BinaryItem::getStringValue2(zstring& val) work if val is not empty? It seems that theValue would be prepended to the current content of val. Could we implement this method by emptying val and calling Base64BinaryItem::appendStringValue on it? StreamableBase64BinaryItem::materialize(): - Is there a reason for the number 4048? - In general those might be a lot of re-allocations, if the item is a little larger (e.g. if the item is 1MB, we've got more than 250 re-allocations). I'm not sure where the right trade-off is, but it seems that this parameter might become expensive (if someone materializes a large item that should be streamed …) I just hope that src/zorbaserialization/zorba_class_serializer.cpp works. -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94081 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba
this also fixes bug #933490 -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94081 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94081 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94081 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job ft-base64Binary-2012-02-22T01-41-08.742Z is finished. The final status was: 7 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94074 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
