In the current implementation, the map of the property value looks like:
   null    -> false;
   ""      -> false;
   "true"  -> true;
   "false" -> false;
   "not"   -> false

For compatibility, I think you may only want to update the default value: null or empty property value, otherwise the behavior does not change.

   null    -> true;
   ""      -> true;
   "true"  -> true;
   "false" -> false;
   "not"   -> false

Per the update, "not" property means true. It might not be an issue in practice. I will have you make the final decision. Otherwise, looks fine to me.


On 3/22/2018 8:04 PM, Weijun Wang wrote:
Please take a review of the code change and CSR at



Reply via email to