I added myself as reviewer of the CSR.
Xuelei
Advertising
On 4/7/2018 8:30 PM, Weijun Wang wrote:
This is more natural. Thanks.
Updated webrev at http://cr.openjdk.java.net/~weijun/8200152/webrev.01/.
Do you mind reviewing the CSR also?
Thanks
Max
On Apr 8, 2018, at 10:53 AM, Xuelei Fan <xuelei....@oracle.com> wrote:
In the current implementation, the map of the property value looks like:
null -> false;
"" -> false;
"true" -> true;
"false" -> false;
"not" -> false
For compatibility, I think you may only want to update the default value: null
or empty property value, otherwise the behavior does not change.
null -> true;
"" -> true;
"true" -> true;
"false" -> false;
"not" -> false
Per the update, "not" property means true. It might not be an issue in
practice. I will have you make the final decision. Otherwise, looks fine to me.
Xuelei
On 3/22/2018 8:04 PM, Weijun Wang wrote:
Please take a review of the code change and CSR at
CSR: https://bugs.openjdk.java.net/browse/JDK-8200153
webrev: http://cr.openjdk.java.net/~weijun/8200152/webrev.00/
Thanks
Max
