Never mind, the latest webrev is great!

On 4/9/2018 9:03 AM, Roger Riggs wrote:

I've seen a variety of interpretations of non-standard input for parsing booleans and
it is likely to cause confusion across properties.

I'd prefer that we converge on the interpretation used in the Boolean.parseBoolean.
Which uses:  "true".equalsIgnoreCase(s);

Better yet, call Boolean.parseBoolean!  Will be compatible with the previous GetBooleanAction().

$.02, Roger

On 4/7/2018 10:53 PM, Xuelei Fan wrote:
In the current implementation, the map of the property value looks like:
   null    -> false;
   ""      -> false;
   "true"  -> true;
   "false" -> false;
   "not"   -> false

For compatibility, I think you may only want to update the default value: null or empty property value, otherwise the behavior does not change.

   null    -> true;
   ""      -> true;
   "true"  -> true;
   "false" -> false;
   "not"   -> false

Per the update, "not" property means true.  It might not be an issue in practice.  I will have you make the final decision. Otherwise, looks fine to me.


On 3/22/2018 8:04 PM, Weijun Wang wrote:
Please take a review of the code change and CSR at



Reply via email to