On Tue, 3 Nov 2020 21:03:02 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - style
>> - style & comments
>> - full update
>> - remove old
>> - update
>> - outputsize
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 541:
>
>> 539: throws IllegalBlockSizeException, ShortBufferException {
>> 540: checkDataLength(processed, Math.addExact(len, tagLenBytes));
>> 541:
>
> Now that encrypt(byte[], int, int, byte[], int) may also store data into
> 'ibuffer', shouldn't this encryptFinal() method processes bytes in 'ibuffer'
> before processing 'in'? The check here would also needs to be updated with
> ibuffer.size()? If this is true, can this be covered in the added regression
> tests?
This is not an optimized path for bytebuffers and will never have any data in
ibuffer.
-------------
PR: https://git.openjdk.java.net/jdk/pull/411
