On Thu, 5 Nov 2020 22:54:45 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - style
>> - style & comments
>> - full update
>> - remove old
>> - update
>> - outputsize
>
> test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java line 443:
>
>> 441:
>> 442: datamap.put("AES/GCM/NoPadding", List.of(
>> 443: new Data("AES",
>
> Just curious, is the data self-generated or got from some spec/external
> sources?
The last one, in this diff, is generated by me. The previous ones are KAT.
> test/jdk/javax/net/ssl/SSLSession/CheckSessionContext.java line 34:
>
>> 32: * @run main/othervm -Djdk.tls.client.protocols=TLSv1.3
>> -Djdk.tls.server.enableSessionTicketExtension=true
>> -Djdk.tls.client.enableSessionTicketExtension=false CheckSessionContext
>> 33: * @run main/othervm -Djdk.tls.client.protocols=TLSv1.3
>> -Djdk.tls.server.enableSessionTicketExtension=true
>> -Djdk.tls.client.enableSessionTicketExtension=true CheckSessionContext
>> 34: * @run main/othervm -Djdk.tls.client.protocols=TLSv1.3
>> -Djdk.tls.server.enableSessionTicketExtension=false
>> -Djdk.tls.client.enableSessionTicketExtension=true CheckSessionContext
>
> I am not sure how is this test related to the change?
I think I changed this when I was running the tests so I could see my GCM
results better using TLS. It is not directly testing the change
-------------
PR: https://git.openjdk.java.net/jdk/pull/411
