On Tue, 17 Nov 2020 18:24:35 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:
>> Hello all,
>> This change brings in support for certificates with EdDSA keys (both Ed25519
>> and Ed448) allowing those signature algorithms to be used both on the
>> certificates themselves and used during the handshaking process for messages
>> like CertificateVerify, ServerKeyExchange and so forth.
>
> test/jdk/javax/net/ssl/TLSCommon/TLSWithEdDSA.java line 35:
>
>> 33: * SunJSSE does not support dynamic system properties, no way to
>> re-use
>> 34: * system properties in samevm/agentvm mode.
>> 35: */
>
> Leading white spaces could be removed. I may put this comment before the
> "@test" block to be consistent with other test cases.
No problem, I'll take care of that.
> test/jdk/javax/net/ssl/TLSCommon/TLSWithEdDSA.java line 74:
>
>> 72:
>> 73: public class TLSWithEdDSA extends SSLSocketTemplate {
>> 74: static final boolean DEBUG = false;
>
> I may not use this filed. The debug property could be specified in the
> "@run" tag if needed.
No problem. Will change.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1197
