On Tue, 17 Nov 2020 19:43:25 GMT, Jamil Nimeh <jni...@openjdk.org> wrote:
>> test/jdk/javax/net/ssl/TLSCommon/TLSWithEdDSA.java line 81: >> >>> 79: static final String DEF_ALL_EE = >>> "EE_ECDSA_SECP256R1:EE_ECDSA_SECP384R1:" + >>> 80: "EE_ECDSA_SECP521R1:EE_RSA_2048:EE_EC_RSA_SECP256R1:" + >>> 81: "EE_DSA_2048:EE_DSA_1024:EE_ED25519:EE_ED448"; >> >> Why not use enum, array or collection directly? Which is easy to read, I >> think. > > I don't think there's any reason why we could use a > Collection<SSLSocketTemplate.Cert> for these. I'll try switching to that. Xuelei, I went back and looked at my rationale for using Strings here. The reason I went with this approach was so I could have client and server parameter maps of <ParamType, String>. I had a common form for parameters that I'd want to set/reset/change between each type of test run. If I were to go with something like a Collection<SSLSocketTemplate.Cert> then my client and server parameter maps would end up needing to be <ParamType, Object> and then I'd have to cast based on the param type. Not sure if changing from the Strings ends up being more clear int the long run. ------------- PR: https://git.openjdk.java.net/jdk/pull/1197
