On Fri, 16 Apr 2021 11:24:57 GMT, Sean Coffey <[email protected]> wrote:
> Added capability to allow the PKCS11 Token to be destroyed once a session is
> logged out from. New configuration properties via pkcs11 config file. Cleaned
> up the native resource poller also.
>
> New unit test case to test behaviour. Some PKCS11 tests refactored to allow
> pkcs11 provider to be configured (and tested) with a config file of choice.
>
> Reviewer request @valeriepeng
test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 42:
> 40: import jdk.test.lib.util.ForceGC;
> 41:
> 42: public class MultipleLogins extends PKCS11Test {
The overall pattern seems a bit different from the typical PKCS11Test usage
pattern. When a class extends PKCS11Test, the main test functionality is under
its main(Provider) method. It is expected that the PKCS11Test class will call
the main(Provider) method with the to-be-tested PKCS11 provider obj. Here it
seems that you are doing that in the static main(String[]) method. Do you
really need to extend PKCS11Test then?
-------------
PR: https://git.openjdk.java.net/jdk/pull/3544
