On Wed, 21 Apr 2021 01:26:18 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Added capability to allow the PKCS11 Token to be destroyed once a session is >> logged out from. New configuration properties via pkcs11 config file. >> Cleaned up the native resource poller also. >> >> New unit test case to test behaviour. Some PKCS11 tests refactored to allow >> pkcs11 provider to be configured (and tested) with a config file of choice. >> >> Reviewer request @valeriepeng > > I will take a look. Thanks! Thanks for the review @valeriepeng Apologies for delay, had to finish up other tasks -- I've made all suggested edits that you made for src/ code and pushed those changes to my branch. For the testing, then I recall the PKCS11Test framework not being able to return multiple PKCS11 Providers to me for testing (an array of providers) -- I thought editing the framework for such a use case would be useful but perhaps I'm better off just writing a customized test. I'm going to take a stab at that and will re-submit a test edit. Apologies for including the Login.java/ Login.sh edits - they were old left over edits from testing efforts before moving on to develop the new MultipleLogins.java test. ------------- PR: https://git.openjdk.java.net/jdk/pull/3544
