On Fri, 17 Sep 2021 23:22:21 GMT, Valerie Peng <valer...@openjdk.org> wrote:
> Anyone has time to review this RFE for adding AES cipher with KW, KWP modes
> support to SunPKCS11 provider?
>
> The main changes are in only one new class, i.e. P11KeyWrapCipher.java, which
> is the CipherSpi impl for the native PKCS11 key wrap mechanisms. When testing
> against NSS library, it seems that they only support the single part enc/dec
> PKCS11 APIs, so have to use a new class as existing P11Cipher class relies on
> the multi part enc/dec PKCS11 APIs and do not support key wrapping/unwrapping.
>
> The rest are minor code refactoring and updates for the PKCS11 Exception
> class.
> The new regression tests are adapted from existing key wrap regression tests
> for SunJCE provider.
>
> Thanks,
> Valerie
test/jdk/sun/security/pkcs11/Cipher/KeyWrap/TestGeneral.java line 30:
> 28: * AES/KW/PKCS5Padding, and AES/KWP/NoPadding impls of SunPKCS11
> provider.
> 29: * @library /test/lib ../..
> 30: * @run main/othervm TestGeneral
General question about all the tests. They use othervm, did they not work with
agentvm?
test/jdk/sun/security/pkcs11/Cipher/KeyWrap/TestGeneral.java line 74:
> 72: }
> 73:
> 74: //System.out.println("enc out.length=" + out.length);
Lelftover debug line?
-------------
PR: https://git.openjdk.java.net/jdk/pull/5569
