On Thu, 30 Sep 2021 23:05:44 GMT, Anthony Scarpino <ascarp...@openjdk.org>
wrote:
>> Anyone has time to review this RFE for adding AES cipher with KW, KWP modes
>> support to SunPKCS11 provider?
>>
>> The main changes are in only one new class, i.e. P11KeyWrapCipher.java,
>> which is the CipherSpi impl for the native PKCS11 key wrap mechanisms. When
>> testing against NSS library, it seems that they only support the single part
>> enc/dec PKCS11 APIs, so have to use a new class as existing P11Cipher class
>> relies on the multi part enc/dec PKCS11 APIs and do not support key
>> wrapping/unwrapping.
>>
>> The rest are minor code refactoring and updates for the PKCS11 Exception
>> class.
>> The new regression tests are adapted from existing key wrap regression tests
>> for SunJCE provider.
>>
>> Thanks,
>> Valerie
>
> test/jdk/sun/security/pkcs11/Cipher/KeyWrap/TestGeneral.java line 74:
>
>> 72: }
>> 73:
>> 74: //System.out.println("enc out.length=" + out.length);
>
> Lelftover debug line?
Yes, will remove.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5569
