On Mon, 11 Oct 2021 23:32:26 GMT, Valerie Peng <valer...@openjdk.org> wrote:

>> Anyone has time to review this RFE for adding AES cipher with KW, KWP modes 
>> support to SunPKCS11 provider?
>> 
>> The main changes are in only one new class, i.e. P11KeyWrapCipher.java, 
>> which is the CipherSpi impl for the native PKCS11 key wrap mechanisms. When 
>> testing against NSS library, it seems that they only support the single part 
>> enc/dec PKCS11 APIs, so have to use a new class as existing P11Cipher class 
>> relies on the multi part enc/dec PKCS11 APIs and do not support key 
>> wrapping/unwrapping.
>> 
>> The rest are minor code refactoring and updates for the PKCS11 Exception 
>> class.
>> The new regression tests are adapted from existing key wrap regression tests 
>> for SunJCE provider.
>> 
>> Thanks,
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Minor update for review comments.

I have marked the CSR as reviewed

-------------

PR: https://git.openjdk.java.net/jdk/pull/5569

Reply via email to