On Mon, 28 Mar 2022 14:12:36 GMT, Sean Mullan <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More minor edits.
>
> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 32:
>
>> 30: /**
>> 31: * This class specifies a parameter spec for RSASSA-PSS signature scheme,
>> 32: * as defined in the
>
> On line 31, add "the" before "RSASSA-PSS".
Ok.
> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 67:
>
>> 65: * }
>> 66: * </pre>
>> 67: * <p>Note: the {@code PSSParameterSpec.DEFAULT} uses the following:
>
> Suggest rewording as:
> `Note: {@code PSSParameterSpec.DEFAULT} uses the following values:`
This part has been removed to reduce duplication since there is already javadoc
for DEFAULT below.
> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 77:
>
>> 75: * from the PKCS#1 standard and may become obsolete as time progresses.
>> 76: * Please do not rely on {@code PSSParameterSpec.DEFAULT} unless these
>> 77: * values are really what you want to use.
>
> Some suggested rewordings:
>
> `Its values are based on the default values defined in the PKCS#1 standard,
> as defined above. Some of these defaults are no longer recommended due to
> advances in cryptanalysis -- see RFC 8017 for more details. Thus, {@code
> PSSParameterSpec.DEFAULT} is deprecated and should be used at your own risk.`
Thanks for the rewording suggestion. This part has been removed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7913
