On Thu, 9 May 2024 15:01:24 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   a start on the preview wire on/off
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 47:
> 
>> 45:     final class Builder {
>> 46: 
>> 47:         Extract extract = null;
> 
> No need to store an `extract` field. Just create one and return it in 
> `extractOnly`.

This field is required for checks in other functions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1597222648

Reply via email to