On Fri, 10 May 2024 14:58:38 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line >> 108: >> >>> 106: * >>> 107: * @param ikm >>> 108: * the ikm value (null values will not be added) >> >> Are you sure about allowing `null`? Any valid use case? Same question for >> the other `add` methods. > > `null` should not be silently ignored. The method should throw > `NullPointerException` (and that should be added to the javdoc in an > `@throws` clause). see: fa60b0188e1 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598678517
