On Thu, 9 May 2024 15:14:48 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> replace in-place SecretKeySpec alg for IKM/salt with "Generic" > > src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 241: > >> 239: private final List<SecretKey> salts; >> 240: >> 241: private Extract() { > > This method is useless if we remove the `extract` object in `Builder`. See related comment. Will plan to leave it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1597226538