On Wed, 15 May 2024 19:59:59 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > javadoc formatting src/java.base/share/classes/javax/crypto/KDF.java line 202: > 200: * @param provider > 201: * the provider to use for this key derivation; if null, this > method is > 202: * equivalent to {@code getInstance(String)} It might be better to disallow null here. If the code doesn't have a provider name then it would be clearer to use the 1-arg getInstance method. That would also help catch bugs where the provider name is null due to some bug. src/java.base/share/classes/javax/crypto/KDF.java line 228: > 226: > 227: /** > 228: * Returns a {code KDF} object that implements the specified > algorithm from Missing the `@` here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1602698687 PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1602696489
