On Wed, 15 May 2024 19:59:59 GMT, Kevin Driver <kdri...@openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are 
>> cryptographic algorithms for deriving additional keys from a secret key and 
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   javadoc formatting

src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 270:

> 268: 
> 269:     /**
> 270:      * Returns a builder for building {@code Extract}-Only and {@code 
> ExtractThenExpand} objects.

The class description speaks of Extract-Only operations. Here we are talking 
about the Extract object so I think confusing to have "-Only" appended to the 
class name. I see the same in the expandOnly method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1602686623

Reply via email to