On Thu, 16 May 2024 06:26:12 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> javadoc formatting
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 270:
>
>> 268:
>> 269: /**
>> 270: * Returns a builder for building {@code Extract}-Only and {@code
>> ExtractThenExpand} objects.
>
> The class description speaks of Extract-Only operations. Here we are talking
> about the Extract object so I think confusing to have "-Only" appended to the
> class name. I see the same in the expandOnly method.
Yes, I agree with (and prefer) the original `Extract` naming convention. This
change was suggested during code reviews, but I can revert it to be as you
suggest.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1603628488
