On Thu, 5 Sep 2024 15:43:29 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change impl class to use byte arrays rather than SecretKey objects where >> possible > > src/java.base/share/classes/javax/crypto/KDF.java line 74: > >> 72: * single object concurrently should synchronize amongst themselves and >> 73: * provide the necessary locking. Multiple threads each manipulating >> separate >> 74: * objects need not synchronize. > > That's great information to the reader, nice! 👍 +1. Looks good. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1746023331
