On Tue, 17 Sep 2024 21:52:47 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > refinement of addIKM and addSalt specifications src/java.base/share/classes/javax/crypto/KDF.java line 405: > 403: > 404: } catch (NoSuchAlgorithmException nsae) { > 405: return handleException(nsae); Is there really scenario requiring `handleException()`? I mean, is there really `NoSuchAlgorithmException` object containing `InvalidAlgorithmParameterException` as cause and need to be thrown as `InvalidAlgorithmParameterException`? Can you show a possible call path for this to happen? Same goes for the other `handleException()` call on line 457. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1765399097
