On Wed, 18 Sep 2024 14:33:55 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refinement of addIKM and addSalt specifications
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 163:
>
>> 161: /**
>> 162: * Adds input keying material (IKM) to the builder. Note that an
>> 163: * {@code ikm} byte array of length zero will discarded.
>
> Typo, should be "will be discarded". Same as below.
Addressed in
https://github.com/openjdk/jdk/pull/20301/commits/f786a38179651a5bca8c4884eeb52d2cef0adc78.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1769196601
