On Fri, 20 Sep 2024 20:07:07 GMT, Kevin Driver <[email protected]> wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 405:
>>
>>> 403:
>>> 404: } catch (NoSuchAlgorithmException nsae) {
>>> 405: return handleException(nsae);
>>
>> Is there really scenario requiring `handleException()`? I mean, is there
>> really `NoSuchAlgorithmException` object containing
>> `InvalidAlgorithmParameterException` as cause and need to be thrown as
>> `InvalidAlgorithmParameterException`? Can you show a possible call path for
>> this to happen?
>> Same goes for the other `handleException()` call on line 457.
>
> This is to surface wrapped `IAPE`s. I'll have to do some digging to see
> whether this is still possible after the recent DPS refactoring; however, it
> was possible at one point.
Removed in
https://github.com/openjdk/jdk/pull/20301/commits/bd1f658fb334765f656a9411149e6572a8ecdb6e.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1772017989