On Fri, 4 Oct 2024 20:59:45 GMT, Ben Perez <bpe...@openjdk.org> wrote:
> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 src/java.base/share/classes/sun/security/provider/ML_DSA.java line 437: > 435: s2PackedLength = 384; > 436: s1s2CoeffSize = 3; > 437: wCoeffSize = 6; Would it make sense to create an object or `record` to group all these values together? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1792116257