On Thu, 10 Oct 2024 15:40:48 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> renamed internal keyGen/sign/verify functions to be same as spec > > src/java.base/share/classes/sun/security/provider/ML_DSA.java line 916: > >> 914: this.xof = xof; >> 915: this.bitsPerCall = bitsPerCall; >> 916: bitMask = (1 << bitsPerCall) - 1; > > Add some comments about the limit of `bitsPerCall`, looks like cannot exceed > 31. BitsPerCall can only be 4 (when called from sampleS1S2()) or 8 (when called from sampleInBall()), so this is not a problem. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1796811481
