On Tue, 8 Oct 2024 15:38:18 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme >> https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on >> https://github.com/openjdk/jdk/pull/21167 > > src/java.base/share/classes/sun/security/provider/ML_DSA.java line 418: > >> 416: >> 417: public ML_DSA(int security_level) { >> 418: switch (security_level) { > > Might want a comment about why there are only `security_level` values of 2, > 3, & 5. I See elsewhere this corresponds to the three "strength" values for the algorithm. Perhaps then, some constants such as `static final int ML-DSA-44 = 2;`. Just a suggestion. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1792142142
