On Wed, 30 Oct 2024 20:14:04 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> apparently <p> can't be before a @implNote.. Who know. > > src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line > 339: > >> 337: * @throws IllegalArgumentException when an argument causes an >> 338: * initialization error. >> 339: * @throws SecurityException on a cryptographic errors. > > Oh, I didn't notice this before. Have we decided to repurpose > `SecurityException` for this usage now that there will be no more Security > Manager? I'm not sure if it was exclusively a Security Manager exception, but @seanjmullan had said previously that `SecurityException` was used elsewhere. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1823616277