On Tue, 29 Oct 2024 18:34:45 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> apparently <p> can't be before a @implNote.. Who know.
>
> src/java.base/share/classes/java/security/PEMDecoder.java line 316:
>
>> 314: if
>> ((PKCS8EncodedKeySpec.class).isAssignableFrom(tClass)) {
>> 315: getKeyFactory(key.getAlgorithm()).
>> 316: getKeySpec(key, PKCS8EncodedKeySpec.class);
>
> Did you forget to assign above to `so`?
Ah yes, and that may address a bug found by testing a few days ago.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1823618364
