On Wed, 30 Oct 2024 20:14:58 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> apparently <p> can't be before a @implNote.. Who know. > > src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line > 440: > >> 438: >> 439: /** >> 440: * Return a PrivateKey from the object's encrypted data with a >> KeyFactory > > Should be `SecretKeyFactory`. Same in `@param provider` below. > > Also, "Return a key" is not clear. Existing `getKeySpec` methods use > "Extract". You maybe also use "Recover". I think "Return" is very clear and I'm not a fan of "Extract" or "Recover". The other methods are overly descriptive of the method's internals rather than the just stating the purpose. Even with that, the other methods end with "returns it." ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1823645238
