On Wed, 6 Nov 2024 13:56:09 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> "Cipher suites must start with TLS_" doc update
>
> src/java.base/share/classes/sun/security/util/AbstractAlgorithmConstraints.java
> line 118:
>
>> 116: if
>> (!pattern.toUpperCase(Locale.ENGLISH).startsWith("TLS_")) {
>> 117: throw new IllegalArgumentException(
>> 118: "Wildcard pattern should start with 'TLS_'");
>
> s/should/must/
Done
> test/jdk/sun/security/ssl/CipherSuite/NoDesRC4DesEdeCiphSuite.java line 46:
>
>> 44: import java.util.Arrays;
>> 45:
>> 46: public class NoDesRC4DesEdeCiphSuite {
>
> I suggest making a new abstract class with the general test methods, and then
> making this a subclass of it.
Will do
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21841#discussion_r1831320053
PR Review Comment: https://git.openjdk.org/jdk/pull/21841#discussion_r1831313955
