On Wed, 6 Nov 2024 21:27:05 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> The current syntax of the jdk.tls.disabledAlgorithms makes it difficult to >> disable algorithms that affect both the key exchange and authentication >> parts of a TLS cipher suite. For example, if you add "RSA" to the >> jdk.tls.disabledAlgorithms security property, it disables all cipher suites >> that use RSA, whether it is for key exchange or authentication. If you only >> want to disable cipher suites that use RSA for key exchange, the only >> workaround is to list the whole cipher suite name, so an exact match is >> done, but if there are many cipher suites that use that key exchange >> algorithm, this becomes cumbersome. > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > - Cache the patterns > - Make matching case-sensitive > - Update java.security documentation > - Refactor the tests src/java.base/share/classes/sun/security/util/AbstractAlgorithmConstraints.java line 126: > 124: } > 125: > 126: Pattern p = patternCache.get(pattern); I think you want to use `putIfAbsent` here, so the operation happens atomically. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21841#discussion_r1833210372
