On Thu, 7 Nov 2024 20:46:13 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Here we have a launcher and several algorithm-specific tests. Users can
>> populate "internalProjection.json" files generated by NIST's ACVP Server
>> into the `data` directory and test them with the launcher.
>>
>> Currently, only SHA2, SHA3, ML-KEM, and ML-DSA are supported.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> more precise ML-DSA sigVer negative test
test/jdk/sun/security/provider/acvp/ML_DSA_Test.java line 46:
> 44: }
> 45:
> 46: static void mldsaGen(JSONValue kat, Provider p) throws Exception {
Since this class is called MD_DSA_Test, is it redundant to use "mldsa" in every
method name? It might be cleaner to just call then "generate", "sign", and
"verify".
test/jdk/sun/security/provider/acvp/ML_KEM_Test.java line 46:
> 44: }
> 45:
> 46: static void mlkemGen(JSONValue kat, Provider p) throws Exception {
Same comment about naming.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1834875233
PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1834875451
