On Fri, 8 Nov 2024 18:23:13 GMT, Matthew Donovan <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more precise ML-DSA sigVer negative test
>
> test/jdk/sun/security/provider/acvp/ML_DSA_Test.java line 46:
>
>> 44: }
>> 45:
>> 46: static void mldsaGen(JSONValue kat, Provider p) throws Exception {
>
> Since this class is called MD_DSA_Test, is it redundant to use "mldsa" in
> every method name? It might be cleaner to just call then "generate", "sign",
> and "verify".
Sure. I'll modify the names. These were originally one big file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1835091439
