On Sat, 15 Feb 2025 14:28:04 GMT, Weijun Wang <[email protected]> wrote:
>> The example code in the JEP was much clearer than that in the current `KEM`
>> class. It's easier to keep the various nested classes straight, rather than
>> using `var`s which require scrolling to see what the return types are.
>>
>> Added/tweaked example for clarity.
>>
>> Generated/checked javadocs, but no regression/JCK tests is necessary.
>
> src/java.base/share/classes/javax/crypto/KEM.java line 76:
>
>> 74: *
>> 75: * // Sender side
>> 76: * KEM senderKEM = KEM.getInstance("ABC-KEM");
>
> Maybe we should rename the `KEM` and `AlgorithmParameters` algorithms to
> "ABC". Modern KEM and signature algorithms are usually the same as the key
> algorithm names.
Sure, I can update this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23652#discussion_r1957192971
