On Sat, 15 Feb 2025 22:33:46 GMT, Bradford Wetmore <[email protected]> wrote:
>> The example code in the JEP was much clearer than that in the current `KEM`
>> class. It's easier to keep the various nested classes straight, rather than
>> using `var`s which require scrolling to see what the return types are.
>>
>> Added/tweaked example for clarity.
>>
>> Generated/checked javadocs, but no regression/JCK tests is necessary.
>
> Bradford Wetmore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Further codereview Comments from Weijun
Reviewed this after you already integrated and noticed the typo.
src/java.base/share/classes/javax/crypto/KEM.java line 68:
> 66: * <p>
> 67: *
> 68: * Example operation using a ficticious {@code KEM} algorithm {@code ABC}:
Typo: s/ficticious/fictitious/
-------------
PR Review: https://git.openjdk.org/jdk/pull/23652#pullrequestreview-2624366617
PR Review Comment: https://git.openjdk.org/jdk/pull/23652#discussion_r1960192397
